On 11/24/25 08:03, Bruce Ashfield wrote:


On Sun, Nov 23, 2025 at 11:44 AM Kai Kang via lists.yoctoproject.org <https://urldefense.com/v3/__http://lists.yoctoproject.org__;!!AjveYdw8EvQ!f3d48tzdQkpUyrZM_186jCRR7-tIHrVCkqWuue1VUv-7RnRL82gWps-Smai_Y-dQgyizt85e_jnLsZig3zh0Z-2YtQ$> <[email protected]> wrote:

    From: Kai Kang <[email protected]>

    When nftables exists, libvirt uses it as default firewall backend.
    Then
    it requires command `tc` to start default network interface:

    libvirtd[653]: Cannot find 'tc' in path: No such file or directory


Which implies that the dependency should be conditional.

OK. I'll add a package config to choose a firewall backend, either iptables or nftables.




    And tweak formats at same time, including replace tab with spaces for
    indent and remove trailing whitespaces.


When you write a commit message like that, you can probably guess
what I will say.

Keep the whitespace patch separate, and chances are, that I'd rather
just leave it as-is, since it makes git blame annoying to diagnose
issues.

Got it.

Kai


Bruce


    Signed-off-by: Kai Kang <[email protected]>
    ---
     recipes-extended/libvirt/libvirt_git.bb
    
<https://urldefense.com/v3/__http://libvirt_git.bb__;!!AjveYdw8EvQ!f3d48tzdQkpUyrZM_186jCRR7-tIHrVCkqWuue1VUv-7RnRL82gWps-Smai_Y-dQgyizt85e_jnLsZig3ziV9EnsEQ$>
    | 12 ++++++------
     1 file changed, 6 insertions(+), 6 deletions(-)

    diff --git a/recipes-extended/libvirt/libvirt_git.bb
    
<https://urldefense.com/v3/__http://libvirt_git.bb__;!!AjveYdw8EvQ!f3d48tzdQkpUyrZM_186jCRR7-tIHrVCkqWuue1VUv-7RnRL82gWps-Smai_Y-dQgyizt85e_jnLsZig3ziV9EnsEQ$>
    b/recipes-extended/libvirt/libvirt_git.bb
    
<https://urldefense.com/v3/__http://libvirt_git.bb__;!!AjveYdw8EvQ!f3d48tzdQkpUyrZM_186jCRR7-tIHrVCkqWuue1VUv-7RnRL82gWps-Smai_Y-dQgyizt85e_jnLsZig3ziV9EnsEQ$>
    index 681ceade..552c5ffe 100644
    --- a/recipes-extended/libvirt/libvirt_git.bb
    
<https://urldefense.com/v3/__http://libvirt_git.bb__;!!AjveYdw8EvQ!f3d48tzdQkpUyrZM_186jCRR7-tIHrVCkqWuue1VUv-7RnRL82gWps-Smai_Y-dQgyizt85e_jnLsZig3ziV9EnsEQ$>
    +++ b/recipes-extended/libvirt/libvirt_git.bb
    
<https://urldefense.com/v3/__http://libvirt_git.bb__;!!AjveYdw8EvQ!f3d48tzdQkpUyrZM_186jCRR7-tIHrVCkqWuue1VUv-7RnRL82gWps-Smai_Y-dQgyizt85e_jnLsZig3ziV9EnsEQ$>
    @@ -1,4 +1,4 @@
    -DESCRIPTION = "A toolkit to interact with the virtualization
    capabilities of recent versions of Linux."
    +DESCRIPTION = "A toolkit to interact with the virtualization
    capabilities of recent versions of Linux."
     HOMEPAGE = "http://libvirt.org
    
<https://urldefense.com/v3/__http://libvirt.org__;!!AjveYdw8EvQ!f3d48tzdQkpUyrZM_186jCRR7-tIHrVCkqWuue1VUv-7RnRL82gWps-Smai_Y-dQgyizt85e_jnLsZig3zjQ5gXpMw$>"
     LICENSE = "LGPL-2.1-or-later & GPL-2.0-or-later"
     LIC_FILES_CHKSUM =
    "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
    @@ -6,16 +6,16 @@ LIC_FILES_CHKSUM =
    "file://COPYING;md5=b234ee4d69f5fce4486a80fdaf4a4263 \
     SECTION = "console/tools"

     DEPENDS = "bridge-utils gnutls libxml2 lvm2 avahi parted curl
    libpcap util-linux e2fsprogs pm-utils \
    -          iptables dnsmasq readline libtasn1 libxslt-native acl
    libdevmapper libtirpc \
    +           iptables dnsmasq readline libtasn1 libxslt-native acl
    libdevmapper libtirpc \
                python3-docutils-native \
    -          ${@bb.utils.contains('PACKAGECONFIG', 'polkit',
    'shadow-native', '', d)} \
    -          ${@bb.utils.contains('PACKAGECONFIG', 'gnutls',
    'gnutls-native', '', d)}"
    +           ${@bb.utils.contains('PACKAGECONFIG', 'polkit',
    'shadow-native', '', d)} \
    +           ${@bb.utils.contains('PACKAGECONFIG', 'gnutls',
    'gnutls-native', '', d)}"

     # libvirt-guests.sh
    
<https://urldefense.com/v3/__http://libvirt-guests.sh__;!!AjveYdw8EvQ!f3d48tzdQkpUyrZM_186jCRR7-tIHrVCkqWuue1VUv-7RnRL82gWps-Smai_Y-dQgyizt85e_jnLsZig3zi9Bj8jjQ$>
    needs gettext.sh
    
<https://urldefense.com/v3/__http://gettext.sh__;!!AjveYdw8EvQ!f3d48tzdQkpUyrZM_186jCRR7-tIHrVCkqWuue1VUv-7RnRL82gWps-Smai_Y-dQgyizt85e_jnLsZig3zjgzVXQfw$>
     #
     RDEPENDS:${PN} = "gettext-runtime"

    -RDEPENDS:libvirt-libvirtd += "bridge-utils iptables pm-utils
    dnsmasq netcat-openbsd ebtables"
    +RDEPENDS:libvirt-libvirtd += "bridge-utils iptables pm-utils
    dnsmasq netcat-openbsd ebtables iproute2-tc"
     RDEPENDS:libvirt-libvirtd:append:x86-64 = " dmidecode"
     RDEPENDS:libvirt-libvirtd:append:x86 = " dmidecode"
     RDEPENDS:libvirt-libvirtd:append:arm = " dmidecode"
    @@ -232,7 +232,7 @@ do_install:append() {
     ${D}/${systemd_system_unitdir}/libvirtd.service
            fi

    -       # The /run/libvirt directories created by the Makefile are
    +       # The /run/libvirt directories created by the Makefile are
            # wiped out in volatile, we need to create these at boot.
            rm -rf ${D}/run
            install -d ${D}${sysconfdir}/default/volatiles
-- 2.34.1




--
- Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end
- "Use the force Harry" - Gandalf, Star Trek II


--
Kai Kang
Wind River Linux
-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#9456): 
https://lists.yoctoproject.org/g/meta-virtualization/message/9456
Mute This Topic: https://lists.yoctoproject.org/mt/116438591/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to