I pushed the resolution already, but I'll take care of the fixup as well. Thanks for checking.
Bruce On Wed, Aug 27, 2014 at 2:29 PM, Zibo Zhao <[email protected]> wrote: > > On 08/27/2014 12:32 PM, Bruce Ashfield wrote: >> >> I had to resolve a reject on this one, so double check that your >> meta-virt tree is >> up to date, and also check that my resolution was correct. > > Sorry, Bruce. I certainly didn't pick up your latest commit regarding > splitting the build/src directories. > So the resolution has a little bit issue: > > > sed -e 's|libdir=|libdir=${PKG_CONFIG_SYSROOT_DIR}|' -i > "${S}/${TEST_SRC_DIR}/protobuf.pc" > > Should have been using ${B} instead of ${S} since the file is in build dir > not in source dir. > Can you fix it or you want me to resubmit the patch? > > Zibo > > >> >> Cheers, >> >> Bruce >> >> On Wed, Aug 27, 2014 at 12:06 PM, Zibo Zhao <[email protected]> >> wrote: >>> >>> While buiding protobuf ptest on Centos 6.4, the build >>> failed with errors: >>> >>> ...libprotobuf.so: undefined reference to `memcpy@GLIBC_2.14' >>> >>> This is due to protobuf.pc still contains /usr/lib64 >>> as libdir which are not good for cross compiling. >>> Replace it with proper sysroot path. >>> >>> Signed-off-by: Zibo Zhao <[email protected]> >>> --- >>> recipes-containers/criu/protobuf_2.5.0.bb | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/recipes-containers/criu/protobuf_2.5.0.bb >>> b/recipes-containers/criu/protobuf_2.5.0.bb >>> index 5c7454b..c4b7d18 100644 >>> --- a/recipes-containers/criu/protobuf_2.5.0.bb >>> +++ b/recipes-containers/criu/protobuf_2.5.0.bb >>> @@ -37,6 +37,7 @@ do_compile_ptest() { >>> # Add the location of the cross-compiled header and library >>> files >>> # which haven't been installed yet. >>> cp "${S}/protobuf.pc" "${S}/${TEST_SRC_DIR}/protobuf.pc" >>> + sed -e 's|libdir=|libdir=${PKG_CONFIG_SYSROOT_DIR}|' -i >>> "${S}/${TEST_SRC_DIR}/protobuf.pc" >>> sed -e 's|Cflags:|Cflags: -I${S}/src|' -i >>> "${S}/${TEST_SRC_DIR}/protobuf.pc" >>> sed -e 's|Libs:|Libs: -L${S}/src/.libs|' -i >>> "${S}/${TEST_SRC_DIR}/protobuf.pc" >>> export PKG_CONFIG_PATH="${S}/${TEST_SRC_DIR}" >>> -- >>> 1.9.1 >>> >>> -- >>> _______________________________________________ >>> meta-virtualization mailing list >>> [email protected] >>> https://lists.yoctoproject.org/listinfo/meta-virtualization >> >> >> > -- "Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end" -- _______________________________________________ meta-virtualization mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-virtualization
