On Tue, Oct 17, 2017 at 12:14 AM, Bruce Ashfield <[email protected]> wrote: > On Mon, Oct 16, 2017 at 9:07 PM, Ricardo Salveti > <[email protected]> wrote: >> On Mon, Oct 16, 2017 at 11:01 PM, Bruce Ashfield >> <[email protected]> wrote: >>> On Mon, Oct 16, 2017 at 8:50 PM, Bruce Ashfield >>> <[email protected]> wrote: >>>> On Mon, Oct 16, 2017 at 5:17 PM, Ricardo Salveti >>>> <[email protected]> wrote: >>>>> runc.inc sets PV based on "${RUNC_VERSION}+git${SRCREV}", which is >>>>> set correctly by runc-opencontainers but not by runc-docker (PV was set >>>>> to 1.0.0-rc3+gitINVALID-r0 instead of using the SRCREV hash). >>>> >>>> Then I'll revert the .inc >>>> >>>> As I mentioned before, I'm keeping the named SRCREVs. I didn't notice that >>>> on >>>> the way in. >>> >>> I see the issue. I won't take this patch, but will fix things up a >>> different way. >> >> Cool, I didn't know if the idea was to use named SRCREV, but handing >> that differently in the .inc should also fix the problem. > > yah. I broke it quite some time ago when I had to split the docker and > open containers runc. > > I should have switched to using SRCPV then .. which I just did now > (and tested both the docker and open-containers variants of runc).
Awesome, just tested your patch and all good from my side as well. Thanks for the fix! Cheers, -- Ricardo Salveti -- _______________________________________________ meta-virtualization mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-virtualization
