On Mon, Apr 9, 2018 at 4:56 PM, Christopher Clark <
christopher.w.cl...@gmail.com> wrote:

> Kurt,
>
> I've reviewed the patches today and all the improvements look good.
>
> Unfortunately, in performing a build with the patches applied to rocko, I
> encountered a link error when attempting:
>   bitbake xen-vtpm
>


This build breakage turned out to be a simple case of /bin/sh pointing to
dash: in that configuration, "echo -e" is broken by dash's builtin
implementation. Adding sed to inject the newlines makes it all work, as per
this patch below, and then it successfully builds to completion.

Christopher


diff --git a/recipes-extended/xen/xen-vtpm.inc
b/recipes-extended/xen/xen-vtpm.inc
index c201f25..4e78d16 100644
--- a/recipes-extended/xen/xen-vtpm.inc
+++ b/recipes-extended/xen/xen-vtpm.inc
@@ -52,7 +52,7 @@ do_configure() {
     # 'sort -V' to natural sort version numbers
     # 'head -n1' to capture the first line of output from sort command

-    if [ "${PV}" = `echo -e "${PV}\n4.9.999" | sort -V | head -n1` ]; then
+    if [ "${PV}" = "$(echo "${PV};4.9.999" | sed 's/;/\n/' | sort -V |
head -n1)" ] ; then
         sed -i "s/^inline/static inline/g" ${B}/vtpmmgr/*.h
     fi
-- 
_______________________________________________
meta-virtualization mailing list
meta-virtualization@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-virtualization

Reply via email to