在 2019/3/7 下午10:00, Mark Hatle 写道:
On 3/6/19 8:58 PM, Dengke Du wrote:
The libvirt recipe in meta-virtualization already define the GROUPADD_PARAM,
so we should append it, not override.
Signed-off-by: Dengke Du <[email protected]>
---
meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
index b55f9a9..0b0f011 100644
--- a/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
+++ b/meta-openstack/recipes-extended/libvirt/libvirt_4.%.bbappend
@@ -5,7 +5,7 @@ PACKAGECONFIG ?= "qemu lxc test remote macvtap libvirtd udev
yajl \
inherit useradd
USERADD_PACKAGES = "${PN}"
-GROUPADD_PARAM_${PN} = "--system libvirt"
+GROUPADD_PARAM_${PN}_append = " ;--system libvirt"
The __append should be fine then, but why the ';'? That part looks wrong, since
typically the PARAM is the parameters passed directly to the groupadd program.
I don't believe ';' is a valid parameter.
Hi Mark
The GROUPADD_PARAM in useradd.bbclass using ';' to create pieces, and
pass each piece to groupadd command,
https://git.openembedded.org/openembedded-core/tree/meta/classes/useradd.bbclass#n54
such as "-r qemu; -r kvm; --system libvirt" into
'-r qemu'
'-r kvm'
'--system libvirt'
to groupadd command.
If we don't use the ';' like this:
'-r qemu -r kvm --system libvirt' pass to groupadd command will fail.
So we should add ';'
--Mark
do_install_append() {
sed -e "s:^#unix_sock_group =:unix_sock_group =:g" -i
${D}/etc/libvirt/libvirtd.conf
--
_______________________________________________
meta-virtualization mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-virtualization
