On Wed, Apr 10, 2019 at 1:06 AM Manjukumar Harthikote Matha <[email protected]> wrote: > > Hi Bruce, > > > -----Original Message----- > > From: Bruce Ashfield [mailto:[email protected]] > > Sent: Monday, April 8, 2019 4:34 AM > > To: Sathees Balya <[email protected]> > > Cc: Filipe Rinaldi <[email protected]>; meta- > > [email protected]; Manjukumar Harthikote Matha > > <[email protected]>; nd <[email protected]> > > Subject: Re: [meta-virtualization] Issues with 50cdecc > > sysvinit-inittab_xen.inc: fix > > hypervisor console > > > > On Mon, Apr 8, 2019 at 7:26 AM Sathees Balya <[email protected]> > > wrote: > > > > > > Hi Bruce, > > > > > > We reverted the commit "50cdecca7b2a0e1bb5eacbec132f26b802f950fc" and > > the console starts as expected. Thanks. > > > > > We should revert this commit, and we can update the patch later after testing > it out on different cases.
ok, I can do that. As long as you are ok with your issue popping back up! I've pushed the revert. Bruce > > Thanks, > Manju > > > > > We had already established that without the commit things start, they were > > starting before we made that change. It was for fixing a different issue > > and for > > standardizing on the use of the variable. > > > > I'm trying to find out if we change the startup check, if the console still > > works. > > > > Bruce > > > > > > > > Regards, > > > Sathees > > > > > > On 08/04/2019, 04:12, "Bruce Ashfield" <[email protected]> wrote: > > > > > > On Thu, Apr 4, 2019 at 4:11 PM Filipe Rinaldi <[email protected]> > > wrote: > > > > > > > > Hi, > > > > > > > > > > > > With regards commit "50cdecc sysvinit-inittab_xen.inc: fix > > > hypervisor > > console"... > > > > > > > > > > > > We are having issues with this patch. When using start_getty (a > > > wrapper to > > getty) it will first check if the console device is a "serial" device > > driver [1]. It then > > fails because hvc0 is a "system" device, not a "serial" [2]. > > > > > > > > > > > > [1] https://github.com/openembedded/openembedded- > > core/blob/master/meta/recipes-core/sysvinit/sysvinit-inittab/start_getty#L11 > > > > > > > > [2] > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/tt > > y/hvc/hvc_console.c#n1036 > > > > > > > > > > > > Any thoughts? > > > > > > Can you confirm that if that check is removed that the console still > > > functions as expected ? > > > > > > Rather than bouncing back and forth between fixing one issue, and > > > creating another, I'm tempted to just bbappend and patch the > > > problematic check out of the startup. But I'm not currently setup to > > > test the issue. > > > > > > Bruce > > > > > > > > > > > > > > > Cheers, > > > > > > > > Filipe > > > > > > > > > > > > IMPORTANT NOTICE: The contents of this email and any attachments are > > confidential and may also be privileged. If you are not the intended > > recipient, > > please notify the sender immediately and do not disclose the contents to any > > other person, use it for any purpose, or store or copy the information in > > any > > medium. Thank you. > > > > -- > > > > _______________________________________________ > > > > meta-virtualization mailing list > > > > [email protected] > > > > https://lists.yoctoproject.org/listinfo/meta-virtualization > > > > > > > > > > > > -- > > > - Thou shalt not follow the NULL pointer, for chaos and madness await > > > thee at its end > > > - "Use the force Harry" - Gandalf, Star Trek II > > > > > > > > > > > > -- > > - Thou shalt not follow the NULL pointer, for chaos and madness await thee > > at > > its end > > - "Use the force Harry" - Gandalf, Star Trek II -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II -- _______________________________________________ meta-virtualization mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-virtualization
