On Wed, May 15, 2019 at 12:07 PM Hongxu Jia <[email protected]> wrote:
> ARM does not currently support NUMA, and defines COMPATIBLE_HOST in recipe > numactl > > Since commit [b5b5def libvirt: add hook support] applied, it failed with > Nothing PROVIDES 'numactl' on ARM BSP, not all BSP define var-KARCH but > define var-TARGET_ARCH > > So check var-TARGET_ARCH, and add numactl to PACKAGECONFIG conditionally > Signed-off-by: Hongxu Jia <[email protected]> > --- > recipes-extended/libvirt/libvirt_5.3.0.bb | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/recipes-extended/libvirt/libvirt_5.3.0.bb > b/recipes-extended/libvirt/libvirt_5.3.0.bb > index 30bb44c..a949e8f 100644 > --- a/recipes-extended/libvirt/libvirt_5.3.0.bb > +++ b/recipes-extended/libvirt/libvirt_5.3.0.bb > @@ -189,9 +189,17 @@ PACKAGECONFIG ??= "qemu yajl openvz vmware vbox esx > iproute2 lxc test \ > ${@bb.utils.contains('DISTRO_FEATURES', 'selinux', > 'selinux audit libcap-ng', '', d)} \ > ${@bb.utils.contains('DISTRO_FEATURES', 'xen', > 'libxl', '', d)} \ > ${@bb.utils.contains('DISTRO_FEATURES', 'x11', > 'polkit', '', d)} \ > - ${@bb.utils.contains('KARCH', 'arm', '', 'numactl', > d)} \ > + ${@support_numactl(d)} \ > " > > +def support_numactl(d): > + targetarch = d.getVar("TARGET_ARCH") > + # ARM does not currently support NUMA > + if targetarch.startswith("arm"): > + return "" > + > + return "numactl" > + > Checking TARGET_ARCH is definitely the right thing to use for this. But out of curiosity, why can't we change it to work the same as the qemu PACKAGECONFIG setting ? i.e. PACKAGECONFIG_remove_arm = "numactl" PACKAGECONFIG_remove_arm64 = "numactl" (or whatever the ARM64 target arch maps to). Bruce > # qemu is NOT compatible with mips64 > PACKAGECONFIG_remove_mipsarchn32 = "qemu" > PACKAGECONFIG_remove_mipsarchn64 = "qemu" > -- > 2.7.4 > > -- > _______________________________________________ > meta-virtualization mailing list > [email protected] > https://lists.yoctoproject.org/listinfo/meta-virtualization > -- - Thou shalt not follow the NULL pointer, for chaos and madness await thee at its end - "Use the force Harry" - Gandalf, Star Trek II
-- _______________________________________________ meta-virtualization mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-virtualization
