Hello, thanks for the fast reply, I am a newbie for patches/formats etc and I would like to learn the convention anyway.
i created meta-virtualization-ci project on github and I don't know this meta targets & setups e2e. i am using for qemuarm target now. but if we can create a list of targets & setups I would like to create e2e ci setup at my home. i also have x86_32/64 and many modern arm boards. I sent another email with descriptions, I am not sure how to reply to this email with git email. https://github.com/cevatbostancioglu/meta-virtualization-ci i think this feature is good for to HEAD, i think if we can at least create build tests for all recipes in layer we don't have to worry about. Bruce Ashfield <[email protected]>, 14 Haz 2019 Cum, 20:44 tarihinde şunu yazdı: > Thanks for the fix. This non-attachment version is easier to review. > > We need a few tweaks and this should be ready to go. > > > > > > * In the long log here, can you capture the compile error and associated > details (i.e. architecture, etc). And then why this error has started now > (was it gcc9, something else ?) .. plus how the fix solves the problem*. > (i disabled the Werror and now i can compile kvmtool) > > You can then duplicate that log log into the patch itself. > > On Fri, Jun 14, 2019 at 12:50 PM Cevat Bostancioglu > <[email protected]> wrote: > > > > Signed-off-by: Cevat Bostancioglu <[email protected]> > > --- > > ...-EXTRA_CFLAGS-variable-and-disable-werror.patch | 26 > +++++++++++++++++++ > > .../0002-kvmtool-add-EXTRA_CFLAGS-variable.patch | 29 > ---------------------- > > recipes-extended/kvmtool/kvmtool.bb | 2 +- > > 3 files changed, 27 insertions(+), 30 deletions(-) > > create mode 100644 > recipes-extended/kvmtool/files/0002-kvmtool-add-EXTRA_CFLAGS-variable-and-disable-werror.patch > > delete mode 100644 > recipes-extended/kvmtool/files/0002-kvmtool-add-EXTRA_CFLAGS-variable.patch > > > > * We should just make this an additional patch, and not modify the > existing one. That way we are keeping some of the history and bisectability > in the changes.(i sent another email, done)* > > > > > diff --git > a/recipes-extended/kvmtool/files/0002-kvmtool-add-EXTRA_CFLAGS-variable-and-disable-werror.patch > b/recipes-extended/kvmtool/files/0002-kvmtool-add-EXTRA_CFLAGS-variable-and-disable-werror.patch > > new file mode 100644 > > index 0000000..d910fae > > --- /dev/null > > +++ > b/recipes-extended/kvmtool/files/0002-kvmtool-add-EXTRA_CFLAGS-variable-and-disable-werror.patch > > @@ -0,0 +1,26 @@ > > +From 8e291af191339471c20292784ebb6de6122f4fc4 Mon Sep 17 00:00:00 2001 > > +From: Cevat Bostancioglu <[email protected]> > > +Date: Fri, 14 Jun 2019 18:47:25 +0300 > > +Subject: [PATCH] kvmtool: add CFLAGS Variable and disable Werror > > + > > +to avoid CFLAGS and warnings via command argument > > You don't have a Signed-off-by: in the patch itself. > > > * .. and finally, is this a good opportunity to update to the HEAD of the > repo and pickup other fixes/features ? ( yes )* > > Bruce > > > +--- > > + Makefile | 3 +++ > > + 1 file changed, 3 insertions(+) > > + > > +diff --git a/Makefile b/Makefile > > +index 030ff4e..e0a8b23 100644 > > +--- a/Makefile > > ++++ b/Makefile > > +@@ -2,6 +2,9 @@ > > + # Define WERROR=0 to disable -Werror. > > + # > > + > > ++WERROR=0 > > ++CFLAGS += $(EXTRA_CFLAGS) > > ++ > > + ifeq ($(strip $(V)),) > > + E = @echo > > + Q = @ > > +-- > > +2.7.4 > > diff --git > a/recipes-extended/kvmtool/files/0002-kvmtool-add-EXTRA_CFLAGS-variable.patch > b/recipes-extended/kvmtool/files/0002-kvmtool-add-EXTRA_CFLAGS-variable.patch > > deleted file mode 100644 > > index 262531c..0000000 > > --- > a/recipes-extended/kvmtool/files/0002-kvmtool-add-EXTRA_CFLAGS-variable.patch > > +++ /dev/null > > @@ -1,29 +0,0 @@ > > -From 977a4d41012d1814f5a5330cacc2e4944de387cc Mon Sep 17 00:00:00 2001 > > -From: Dariusz Pelowski <[email protected]> > > -Date: Sun, 5 Nov 2017 12:39:21 +0100 > > -Subject: [PATCH 2/2] kvmtool: add EXTRA_CFLAGS variable > > - > > -to avoid CFLAGS overriding introduce new EXTRA_CFLAGS variable > > -for setting via command argument > > - > > -Signed-off-by: Dariusz Pelowski <[email protected]> > > ---- > > - Makefile | 2 ++ > > - 1 file changed, 2 insertions(+) > > - > > -diff --git a/Makefile b/Makefile > > -index 64a0a16..bca1b26 100644 > > ---- a/Makefile > > -+++ b/Makefile > > -@@ -2,6 +2,8 @@ > > - # Define WERROR=0 to disable -Werror. > > - # > > - > > -+CFLAGS += $(EXTRA_CFLAGS) > > -+ > > - ifeq ($(strip $(V)),) > > - E = @echo > > - Q = @ > > --- > > -2.15.0 > > - > > diff --git a/recipes-extended/kvmtool/kvmtool.bb > b/recipes-extended/kvmtool/kvmtool.bb > > index cb09c66..acecb08 100644 > > --- a/recipes-extended/kvmtool/kvmtool.bb > > +++ b/recipes-extended/kvmtool/kvmtool.bb > > @@ -13,7 +13,7 @@ SRC_URI = "git:// > git.kernel.org/pub/scm/linux/kernel/git/will/kvmtool.git \ > > file://external-crosscompiler.patch \ > > > file://0001-Avoid-pointers-for-address-of-packed-members.patch \ > > file://0001-kvmtool-9p-fixed-compilation-error.patch \ > > - file://0002-kvmtool-add-EXTRA_CFLAGS-variable.patch \ > > + > file://0002-kvmtool-add-EXTRA_CFLAGS-variable-and-disable-werror.patch \ > > " > > > > SRCREV = "0e1882a49f81cb15d328ef83a78849c0ea26eecc" > > -- > > 2.7.4 > > > > -- > > _______________________________________________ > > meta-virtualization mailing list > > [email protected] > > https://lists.yoctoproject.org/listinfo/meta-virtualization > > > > -- > - Thou shalt not follow the NULL pointer, for chaos and madness await > thee at its end > - "Use the force Harry" - Gandalf, Star Trek II >
-- _______________________________________________ meta-virtualization mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-virtualization
