On Mon, Sep 2, 2019 at 7:53 AM Zheng Ruoqin <[email protected]> wrote:
>
> Signed-off-by: Zheng Ruoqin <[email protected]>
> ---
> .../python/python-glanceclient_git.bb | 18 ++++++++----------
> 1 file changed, 8 insertions(+), 10 deletions(-)
>
> diff --git
> a/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> b/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> index 00ea2ab..e828cba 100644
> --- a/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> +++ b/meta-openstack/recipes-devtools/python/python-glanceclient_git.bb
> @@ -3,22 +3,20 @@ HOMEPAGE =
> "https://github.com/openstack/python-glanceclient";
> SECTION = "devel/python"
> LICENSE = "Apache-2.0"
> LIC_FILES_CHKSUM = "file://LICENSE;md5=34400b68072d710fecd0a2940a0d1658"
> +SRC_URI = "git://github.com/openstack/python-glanceclient.git \
> + file://glance-api-check.sh \
> + "
> +
> +PV = "2.16.0+git${SRCPV}"
> +SRCREV = "44a4dbd6ce2642daeaca9f45ac99e2d1b39e805a"
> +S = "${WORKDIR}/git"
> +
> DEPENDS += " \
> gmp \
> python-pip \
> python-pbr \
> "
>
> -SRCREV = "13b25ff1fed908cfe7b4e719a97efd7121e3be96"
> -PV = "2.8.0+git${SRCPV}"
> -
> -SRC_URI = "\
> - git://github.com/openstack/${BPN}.git;branch=stable/pike \
> - file://glance-api-check.sh \
> - "
> -
> -S = "${WORKDIR}/git"
What's with the extra churn here? Was the moving around of lines
deliberate, if so it needs to be covered in the long log. If not you
should avoid this as it is similar to mixing real changes and non-real
changes, it only serves to make the review more difficult.
MarkA
> -
> inherit setuptools monitor rmargparse
>
> FILES_${PN} += "${datadir}/${SRCNAME}"
> --
> 2.17.1
>
>
>
> --
> _______________________________________________
> meta-virtualization mailing list
> [email protected]
> https://lists.yoctoproject.org/listinfo/meta-virtualization
--
_______________________________________________
meta-virtualization mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-virtualization
