On 12/10/25 3:30 PM, Philip Balister wrote:
Mark, I assume you have seen this. The change really should never have
gone into Scarthgap ...


I'd previously said the same and people fought me on it. (See 11/27) I'm not surprised it's being reverted, I agree it shouldn't have been backported.. even in master, raising a keyerror is wrong. It should be at the most doing a skiprecipe.

So the _go_ change is going into meta-microblaze either way, once I finally get the time. It has a side effect of slightly speeding up parsing since it stops any recipes using go (which won't work on Microblaze anyway!)

--Mark


-------- Forwarded Message --------
Subject: [OE-core][scarthgap][PATCH] Revert "lib/oe/go: document
map_arch, and raise an error on unknown architecture"
Resent-Date: Wed, 10 Dec 2025 11:07:54 -0800
Resent-From: [email protected]
Date: Wed, 10 Dec 2025 20:07:46 +0100
From: Peter Marko via lists.openembedded.org
<[email protected]>
Reply-To: [email protected]
To: [email protected]
CC: Peter Marko <[email protected]>

From: Peter Marko <[email protected]>

This reverts commit e6de433ccb2784581d6c775cce97f414ef9334b1.

This introduced a breaking change which is not suitable for backport to
stable LTS branches.

Signed-off-by: Peter Marko <[email protected]>
---
   meta/lib/oe/go.py | 6 +-----
   1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/meta/lib/oe/go.py b/meta/lib/oe/go.py
index 4559dc63b28..dfd957d157a 100644
--- a/meta/lib/oe/go.py
+++ b/meta/lib/oe/go.py
@@ -7,10 +7,6 @@
   import re
    def map_arch(a):
-    """
-    Map our architecture names to Go's GOARCH names.
-    See
https://github.com/golang/go/blob/master/src/internal/syslist/syslist.go
for the complete list.
-    """
       if re.match('i.86', a):
           return '386'
       elif a == 'x86_64':
@@ -35,4 +31,4 @@ def map_arch(a):
           return 'riscv64'
       elif a == 'loongarch64':
           return 'loong64'
-    raise KeyError(f"Cannot map architecture {a}")
+    return ''





-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#5806): 
https://lists.yoctoproject.org/g/meta-xilinx/message/5806
Mute This Topic: https://lists.yoctoproject.org/mt/116719613/21656
Group Owner: [email protected]
Unsubscribe: https://lists.yoctoproject.org/g/meta-xilinx/unsub 
[[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

Reply via email to