On Tue, May 3, 2016 at 3:28 AM, Manjukumar Harthikote Matha <manjukumar.harthikote-ma...@xilinx.com> wrote: > Hi Nathan, > > On 05/02/2016 08:27 AM, Nathan Rossi wrote: > <...> >>> >>> diff --git a/conf/machine/zynqmp-zcu102.conf >>> b/conf/machine/zynqmp-zcu102.conf >>> new file mode 100644 >>> index 0000000..a41679f >>> --- /dev/null >>> +++ b/conf/machine/zynqmp-zcu102.conf >>> @@ -0,0 +1,21 @@ >>> +#@TYPE: Machine >>> +#@NAME: zynqmp-zcu102 >> >> >> Please follow the existing convention for machine names in >> meta-xilinx. This should be "zcu102-zynqmp". >> > This was named to match with Xilinx kernel board information, dts, configs > etc. > > https://github.com/Xilinx/linux-xlnx/blob/18636b66d01d4f4c22d836226c04a57f2416e16f/arch/arm64/boot/dts/xilinx/zynqmp-zcu102.dts
That's fine, but the convention in meta-xilinx is "<board>-<design-name>-<soc/architecture>". > >>> +#@DESCRIPTION: Machine support for ZCU102 Evaluation Board. >>> +# >>> + >>> +require conf/machine/include/tune-zynqmp.inc >>> +require conf/machine/include/machine-xilinx-default.inc >>> +require conf/machine/include/machine-xilinx-board.inc >>> + >>> +MACHINE_FEATURES = "rtc ext2 ext3 vfat usbhost" >>> + >>> +UBOOT_MACHINE = "xilinx_zynqmp_zcu102_revB_defconfig" >>> + >>> +SERIAL_CONSOLE = "115200 ttyPS0" >>> + >>> +KERNEL_DEVICETREE = "xilinx/zynqmp-zcu102-revB.dtb" >>> +KCONFIG_MODE = "--alldefconfig" >> >> >> This is a kernel variable, why does it need to be set at the machine >> level? >> > Will send a updated v2 patch. > The board configuration will be using the kernel configuration by default > KBUILD_DEFCONFIG_zynqmp = "xilinx_zynqmp_defconfig" > KCONFIG_MODE = "--alldefconfig" Those variables should be set in the corresponding kernel recipe and not in the machine config. Otherwise they will conflict with other kernels that provide support for this machine (e.g. linux-yocto). Regards, Nathan -- _______________________________________________ meta-xilinx mailing list meta-xilinx@yoctoproject.org https://lists.yoctoproject.org/listinfo/meta-xilinx
