On 21 January 2017 at 17:39, Manjukumar Harthikote Matha <[email protected]> wrote: > Hi Nathan, > >> -----Original Message----- >> From: [email protected] [mailto:meta-xilinx- >> [email protected]] On Behalf Of Nathan Rossi >> Sent: Thursday, January 19, 2017 11:12 PM >> To: Vineeth Karumanchi >> Cc: [email protected] >> Subject: Re: [meta-xilinx] [PATCH] linux-xlnx.inc: Add KERNELURI >> >> On 19 January 2017 at 18:04, Vineeth Chowdary Karumanchi >> <[email protected]> wrote: >> > Add KERNELURI for custom kernel url's >> >> Could you elaborate on the reason for this change, maybe its one of the >> following? >> >> * Providing a different mirror to source the git repo >> * Changing the protocol to allow for git/ssh cloning >> * Pointing a a different internal-only source for the linux-xlnx repo > Mainly this, with PetaLinux Tools inheriting Yocto, there is significant > number of request to change SRC_URI to point to different repos. > >> * Having the include more reusable for kernels that are derived from the >> linux-xlnx >> kernel > We have some use case of this as well.
That's fine, just wanted to make sure I understood what the goal of the change was. Applied, but with a minor change to setting KERNELURI with "?=" instead of just "=". So that it is straight forward to set the value from recipes/etc. Thanks, Nathan > > Thanks > Manju > >> >> Thanks, >> Nathan >> >> > >> > Signed-off-by: Vineeth Chowdary Karumanchi >> > <[email protected]> >> > Reviewed-by: Manjukumar Harthikote Matha >> > <[email protected]> >> > --- >> > recipes-kernel/linux/linux-xlnx.inc | 3 ++- >> > 1 file changed, 2 insertions(+), 1 deletion(-) >> > >> > diff --git a/recipes-kernel/linux/linux-xlnx.inc >> > b/recipes-kernel/linux/linux-xlnx.inc >> > index 1474658..dd71324 100644 >> > --- a/recipes-kernel/linux/linux-xlnx.inc >> > +++ b/recipes-kernel/linux/linux-xlnx.inc >> > @@ -9,8 +9,9 @@ KBRANCH ?= "" >> > SRCBRANCHARG = "${@['nobranch=1', >> 'branch=${KBRANCH}'][d.getVar('KBRANCH', True) != '']}" >> > >> > FILESOVERRIDES_append = ":${LINUX_VERSION}" >> > +KERNELURI = "git://github.com/Xilinx/linux-xlnx.git;protocol=https" >> > SRC_URI = " \ >> > - >> > git://github.com/Xilinx/linux-xlnx.git;protocol=https;${SRCBRANCHARG} \ >> > + ${KERNELURI};${SRCBRANCHARG} \ >> > file://xilinx-base;type=kmeta;destsuffix=xilinx-base \ >> > " >> > >> > -- >> > 2.7.4 >> > >> > -- >> > _______________________________________________ >> > meta-xilinx mailing list >> > [email protected] >> > https://lists.yoctoproject.org/listinfo/meta-xilinx >> -- >> _______________________________________________ >> meta-xilinx mailing list >> [email protected] >> https://lists.yoctoproject.org/listinfo/meta-xilinx > > > This email and any attachments are intended for the sole use of the named > recipient(s) and contain(s) confidential information that may be proprietary, > privileged or copyrighted under applicable law. If you are not the intended > recipient, do not read, copy, or forward this email message or any > attachments. Delete this email message and any attachments immediately. > -- _______________________________________________ meta-xilinx mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-xilinx
