> -----Original Message----- > From: Nathan Rossi [mailto:[email protected]] > Sent: Tuesday, May 30, 2017 3:53 AM > To: Manjukumar Harthikote Matha <[email protected]> > Cc: [email protected] > Subject: Re: [meta-xilinx] [PATCH] machine-xilinx-default.inc: Provide > include hooks > > On 27 May 2017 at 08:15, Manjukumar Matha <manjukumar.harthikote- > [email protected]> wrote: > > Provide include hooks for meta-xilinx-tools use. This hook can be > > modified to include bootgen variables in meta-xilinx-tools > > > > Signed-off-by: Cyril Chemparathy <[email protected]> > > Signed-off-by: Manjukumar Matha > > <[email protected]> > > --- > > conf/machine/include/machine-xilinx-default.inc | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/conf/machine/include/machine-xilinx-default.inc > > b/conf/machine/include/machine-xilinx-default.inc > > index 5ab7494..24d78bc 100644 > > --- a/conf/machine/include/machine-xilinx-default.inc > > +++ b/conf/machine/include/machine-xilinx-default.inc > > @@ -1,5 +1,8 @@ > > # Default Xilinx BSP Machine settings > > > > +include conf/machine/include/machine-xilinx-${SOC_FAMILY}.inc > > +include conf/machine/include/machine-xilinx-${MACHINE}.inc > > I am not convinced this a good idea, this creates some weird implicit > relationship > with the meta-xilinx-tools layer. > Hi Nathan,
We maybe using it with meta-xilinx-tools, but in perspective this is an include file which can be utilized in any other meta-layer as dependency wiring. Thanks Manju > Whilst it might not be the perfect solution I think these include directives > should be in > the xilinx-bootbin class (of meta-xilinx-tools), which achieves the same goal > as > having them in machine-xilinx-default.inc but skips the whole layer reverse > dependence oddness. I would probably also consider giving the includes (at > least the > bootbin parts) a different name (e.g. > default-bootbin-<soc>), because if the meta-xilinx layer were to have > includes like > that its very likely one layer would be broken by the other. > > Regards, > Nathan > > > + > > MACHINE_FEATURES_BACKFILL_CONSIDERED += "rtc" > > > > # MicroBlaze cannot handle the execution of qemu-linux-user for > > gobject-introspection-data > > -- > > 2.7.4 > > > > -- > > _______________________________________________ > > meta-xilinx mailing list > > [email protected] > > https://lists.yoctoproject.org/listinfo/meta-xilinx This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. -- _______________________________________________ meta-xilinx mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-xilinx
