> -----Original Message-----
> From: Nathan Rossi [mailto:nat...@nathanrossi.com]
> Sent: Thursday, April 19, 2018 4:54 AM
> To: Manjukumar Harthikote Matha <manju...@xilinx.com>
> Cc: meta-xilinx@yoctoproject.org
> Subject: Re: [meta-xilinx] [meta-xilinx-bsp][PATCH v3] Update recipes for 
> Xilinx
> v2018.1 release
> 
> On 14 April 2018 at 05:58, Manjukumar Matha
> <manjukumar.harthikote-ma...@xilinx.com> wrote:
> > Update the arm-trusted-firmware, u-boot-xlnx, linux-xlnx,
> > qemu-xilinx and qemu-devicetrees recipes for 2018.1 release
> >
> > Tested-by: Jaewon Lee <jaewon....@xilinx.com>
> > Acked-by: Bhargava Sreekantappa Gayathri <bhargava.sreekantappa-
> gayat...@xilinx.com>
> > Signed-off-by: Manjukumar Matha <manjukumar.harthikote-ma...@xilinx.com>
> > ---
> > Changelog:
> > v2: Updated ATF recipes (version is 1.4)
> > v3: Updated QEMU recipe (version is 2.11.0)
> >
> >  .../arm-trusted-firmware/arm-trusted-firmware.inc  |  2 +-
> >  .../arm-trusted-firmware_2018.1.bb                 |  7 +++++++
> >  .../recipes-bsp/u-boot/u-boot-xlnx_2018.1.bb       | 23
> ++++++++++++++++++++++
> >  .../qemu/qemu-devicetrees_2018.1.bb                |  6 ++++++
> >  .../recipes-devtools/qemu/qemu-xilinx_2018.1.bb    |  6 ++++++
> >  .../recipes-kernel/linux/linux-xlnx_2018.1.bb      |  7 +++++++
> >  6 files changed, 50 insertions(+), 1 deletion(-)
> >  create mode 100644 meta-xilinx-bsp/recipes-bsp/arm-trusted-firmware/arm-
> trusted-firmware_2018.1.bb
> >  create mode 100644 meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-xlnx_2018.1.bb
> >  create mode 100644 meta-xilinx-bsp/recipes-devtools/qemu/qemu-
> devicetrees_2018.1.bb
> >  create mode 100644 meta-xilinx-bsp/recipes-devtools/qemu/qemu-
> xilinx_2018.1.bb
> >  create mode 100644 
> > meta-xilinx-bsp/recipes-kernel/linux/linux-xlnx_2018.1.bb
> >
> > diff --git a/meta-xilinx-bsp/recipes-bsp/arm-trusted-firmware/arm-trusted-
> firmware.inc b/meta-xilinx-bsp/recipes-bsp/arm-trusted-firmware/arm-trusted-
> firmware.inc
> > index 2aceba4..7f13507 100644
> > --- a/meta-xilinx-bsp/recipes-bsp/arm-trusted-firmware/arm-trusted-
> firmware.inc
> > +++ b/meta-xilinx-bsp/recipes-bsp/arm-trusted-firmware/arm-trusted-
> firmware.inc
> > @@ -1,7 +1,7 @@
> >  DESCRIPTION = "ARM Trusted Firmware"
> >
> >  LICENSE = "BSD"
> > -LIC_FILES_CHKSUM =
> "file://license.md;md5=829bdeb34c1d9044f393d5a16c068371"
> > +LIC_FILES_CHKSUM =
> "file://license.rst;md5=33065335ea03d977d0569f270b39603e"
> 
> This will break the checksum for the existing recipes. Probably worth
> moving the value into the .bb so it can be matched with the source?
> 
> But I guess the plan will be to drop all but 2018.1 recipes for the
> sumo release correct?
> 

Yes planning to remove 2018.1 recipes

> >
> >  PROVIDES = "virtual/arm-trusted-firmware"
> >
> > diff --git a/meta-xilinx-bsp/recipes-bsp/arm-trusted-firmware/arm-trusted-
> firmware_2018.1.bb b/meta-xilinx-bsp/recipes-bsp/arm-trusted-firmware/arm-
> trusted-firmware_2018.1.bb
> > new file mode 100644
> > index 0000000..6a9eea6
> > --- /dev/null
> > +++ b/meta-xilinx-bsp/recipes-bsp/arm-trusted-firmware/arm-trusted-
> firmware_2018.1.bb
> > @@ -0,0 +1,7 @@
> > +ATF_VERSION = "1.4"
> > +XILINX_RELEASE_VERSION = "v2018.1"
> > +BRANCH ?= "master"
> 
> I understand some of these repos have yet to be tagged publicly with a
> "xilinx-v2018.1" tag. But you should avoid setting the branch unless
> it's specifically needed, since setting the branch prevents the use of
> "nobranch=1" in the src uri. This means in the future if the repo
> changes such that the object cannot be found in the master ref
> (rebases/merges/major tree changes/etc) it will fail to checkout the
> source. This applies to the other recipes in this patch too.
> 

That would be a good catch if that happens, the rebase/merge should never erase 
a previous commit.
I am aware it has happened in the past, however I am inclined not to remove the 
BRANCH argument going forward


> > +SRCREV ?= "df4a7e97d57494c7d79de51b1e0e450d982cea98"
> > +
> > +include arm-trusted-firmware.inc
> > +
> > diff --git a/meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-xlnx_2018.1.bb 
> > b/meta-
> xilinx-bsp/recipes-bsp/u-boot/u-boot-xlnx_2018.1.bb
> > new file mode 100644
> > index 0000000..0b5b085
> > --- /dev/null
> > +++ b/meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-xlnx_2018.1.bb
> > @@ -0,0 +1,23 @@
> > +UBOOT_VERSION = "v2018.01"
> > +XILINX_RELEASE_VERSION = "v2018.1"
> > +
> > +UBRANCH ?= "master"
> > +
> > +SRCREV ?= "1c81b42a326e5b74a5b79e55de9c52b5781b7a8a"
> > +
> > +include u-boot-xlnx.inc
> > +include u-boot-spl-zynq-init.inc
> > +
> > +LICENSE = "GPLv2+"
> > +LIC_FILES_CHKSUM =
> "file://README;beginline=1;endline=6;md5=157ab8408beab40cd8ce1dc69f702a6
> c"
> > +
> > +# u-boot-xlnx has support for these
> > +HAS_PLATFORM_INIT ?= " \
> > +               zynq_microzed_config \
> > +               zynq_zed_config \
> > +               zynq_zc702_config \
> > +               zynq_zc706_config \
> > +               zynq_zybo_config \
> > +               xilinx_zynqmp_zcu102_rev1_0_config \
> > +               "
> > +
> > diff --git 
> > a/meta-xilinx-bsp/recipes-devtools/qemu/qemu-devicetrees_2018.1.bb
> b/meta-xilinx-bsp/recipes-devtools/qemu/qemu-devicetrees_2018.1.bb
> > new file mode 100644
> > index 0000000..a73b9e5
> > --- /dev/null
> > +++ b/meta-xilinx-bsp/recipes-devtools/qemu/qemu-devicetrees_2018.1.bb
> > @@ -0,0 +1,6 @@
> > +require qemu-devicetrees.inc
> > +
> > +XILINX_RELEASE_VERSION = "v2018.1"
> > +
> > +BRANCH ?= "master"
> > +SRCREV ?= "d5017f8119b6493d8b2fcdfd5caa4e8b16580877"
> > diff --git a/meta-xilinx-bsp/recipes-devtools/qemu/qemu-xilinx_2018.1.bb
> b/meta-xilinx-bsp/recipes-devtools/qemu/qemu-xilinx_2018.1.bb
> > new file mode 100644
> > index 0000000..1d6697c
> > --- /dev/null
> > +++ b/meta-xilinx-bsp/recipes-devtools/qemu/qemu-xilinx_2018.1.bb
> > @@ -0,0 +1,6 @@
> > +require qemu-xilinx.inc
> > +
> > +XILINX_RELEASE_VERSION = "v2018.1"
> > +XILINX_QEMU_VERSION ?= "v2.11.0"
> 
> QEMU 2.11 has a configure bug that affects qemu-xilinx too. See the
> patch in oe-core/meta
> (http://git.openembedded.org/openembedded-core/tree/meta/recipes-
> devtools/qemu/qemu/memfd.patch).
> It should probably be copied across to this recipe.
> 

Thanks, will check that

Thanks,
Manju
-- 
_______________________________________________
meta-xilinx mailing list
meta-xilinx@yoctoproject.org
https://lists.yoctoproject.org/listinfo/meta-xilinx

Reply via email to