On 30 April 2018 at 14:36, Manjukumar Harthikote Matha <[email protected]> wrote: > Hi Nathan, > >> -----Original Message----- >> From: Nathan Rossi [mailto:[email protected]] >> Sent: Thursday, April 19, 2018 5:04 AM >> To: Manjukumar Harthikote Matha <[email protected]> >> Cc: [email protected]; Jeegar Patel <[email protected]>; Devarsh >> Thakkar <[email protected]> >> Subject: Re: [meta-xilinx] [meta-xilinx-bsp][PATCH] >> recipes-multimedia/vcu/*.bb: >> Introduce hwcodec and required firmware, ko and software libraries for VCU >> >> On 14 April 2018 at 06:20, Manjukumar Matha <manjukumar.harthikote- >> [email protected]> wrote: >> > From: Devarsh Thakkar <[email protected]> >> > >> > Add new recipes for the following: >> > >> > vcu-firmware_git.bb: Add a new recipe to fetch the required firmware >> > binaries for VCU >> > >> > kernel-module-vcu_git.bb: Add new recipe for out-of-tree kernel module >> > required for VCU decoder, encoder. This is applicable to MPSoC EV >> > devices which support Video Codec Unit >> > >> > libvcu-xlnx_git.bb: Add a new recipe for control software libraries, >> > test applications and headers for VCU >> > >> > libomxil-xlnx_git.bb: Add VCU hwcodec, this contain the OpenMAX >> > libraries, test applications and headers for VCU >> > >> > Signed-off-by: Devarsh Thakkar <[email protected]> >> > Signed-off-by: Jeegar Patel <[email protected]> >> > Tested-by: Maulik Desai <[email protected]> >> > Acked-by: Varunkumar Allagadapa <[email protected]> >> > Reviewed-by: Bhargava Sreekantappa Gayathri >> > <[email protected]> >> > Signed-off-by: Manjukumar Matha >> > <[email protected]> >> > --- >> > .../vcu/kernel-module-vcu_git.bb | 26 +++++++++++++ >> > .../recipes-multimedia/vcu/libomxil-xlnx_git.bb | 45 >> > ++++++++++++++++++++++ >> > .../recipes-multimedia/vcu/libvcu-xlnx_git.bb | 37 ++++++++++++++++++ >> > .../recipes-multimedia/vcu/vcu-firmware_git.bb | 37 ++++++++++++++++++ >> > 4 files changed, 145 insertions(+) >> > create mode 100644 >> > meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb >> > create mode 100644 >> > meta-xilinx-bsp/recipes-multimedia/vcu/libomxil-xlnx_git.bb >> > create mode 100644 >> > meta-xilinx-bsp/recipes-multimedia/vcu/libvcu-xlnx_git.bb >> > create mode 100644 >> > meta-xilinx-bsp/recipes-multimedia/vcu/vcu-firmware_git.bb >> > >> > diff --git >> > a/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb >> > b/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb >> > new file mode 100644 >> > index 0000000..cfd99d9 >> > --- /dev/null >> > +++ b/meta-xilinx-bsp/recipes-multimedia/vcu/kernel-module-vcu_git.bb >> > @@ -0,0 +1,26 @@ >> > +SUMMARY = "Linux kernel module for Video Code Unit" >> > +DESCRIPTION = "Out-of-tree VCU decoder, encoder and common kernel >> modules provider for MPSoC EV devices" >> > +SECTION = "kernel/modules" >> > +LICENSE = "GPLv2" >> > +LIC_FILES_CHKSUM = >> "file://LICENSE.md;md5=eb723b61539feef013de476e68b5c50a" >> > + >> > +XILINX_VCU_VERSION = "1.0.0" >> > +PV = "${XILINX_VCU_VERSION}" >> > + >> > +S = "${WORKDIR}/git" >> > + >> > +BRANCH ?= "master" >> >> Same comment as with the v2018.1 updates, avoid setting the branch unless it >> is >> specifically needed. >> >> > +REPO ?= "git://github.com/xilinx/vcu-modules.git;protocol=https" >> > +SRCREV ?= "646185390cc1850969c0fa3db59fc8f0e511922e" >> >> So I noticed most of these repos have the standard Xilinx release >> versioning, e.g. >> xilinx-v201... tags. Should these recipes follow the same convention as the >> other >> Xilinx trees? e.g. <recipename>_2018.1.bb and have the PV = >> "${XILINX_VCU_VERSION}-xilinx-${XILINX_RELEASE_VERSION}" (or just >> "${XILINX_RELEASE_VERSION}"). >> > > The more I think about it, it is better to stick with recipes saying _git.bb > and having PV = "${XILINX_VCU_VERSION} > -xilinx-${XILINX_RELEASE_VERSION}+git${SRCPV}". This also follows upstream > nomenclature of having recipes which use git as _git.bb > > I am also planning to change other recipes as well, no reason to deviate from > upstream. >
For reference we have had this discussion before. https://lists.yoctoproject.org/pipermail/meta-xilinx/2017-May/002821.html To add to that threads details around _git.bb. There is no distinct nomenclature around the use of _git.bb in other layers (especially oe-core). Some use it to indicate the source is from git, others use it as a means to provide the newest version from source control (compared to other versions of the recipe using source tarballs). Some recipes use _git.bb and don't use the SRCPV in the PV. And there are recipes that use git sources that are not named _git.bb (e.g. glibc_2.27.bb). At the end of the day the filename matters very little assuming the PV is set in the recipe as that is the important value, especially for these recipes since its very likely there will only be one version available at a time. So you could just leave the version part of the recipe filename off entirely and just use e.g. "kernel-module-vcu.bb" (like kernel-module-mali). Regards, Nathan -- _______________________________________________ meta-xilinx mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-xilinx
