________________________________________ From: [email protected] <[email protected]> on behalf of Jean-Francois Dagenais <[email protected]> Sent: Saturday, December 8, 2018 4:11 AM To: Alejandro Enedino Hernandez Samaniego Cc: [email protected] Subject: Re: [meta-xilinx] [PATCH 9/9] zynqmp-pmu: Remove class that uses a multilib hack to build standalone components
On Dec 6, 2018, at 4:56 PM, Alejandro Enedino Hernandez Samaniego <[email protected]<mailto:[email protected]>> wrote: diff --git a/meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-spl-zynq-init.inc b/meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-spl-zynq-init.inc index 9cf09ff..6233bc8 100644 --- a/meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-spl-zynq-init.inc +++ b/meta-xilinx-bsp/recipes-bsp/u-boot/u-boot-spl-zynq-init.inc @@ -65,7 +65,7 @@ python () { if providesbin and d.getVar("SOC_FAMILY") in ["zynqmp"]: # depend on the pmu-firmware build - d.appendVar("DEPENDS", " virtual/pmu-firmware") + #d.appendVar("DEPENDS", " virtual/pmu-firmware") Just delete the line, let's not accumulate stale, commented code around. I assume this dependency would need to be adapted into the multi-config setup, however I am surprised it is completely removed - it still exists (in case of SPL) right? Perhaps I am missing it, but I don't see it reintroduced anywhere? The multi-config setup (as described here: https://lists.yoctoproject.org/pipermail/meta-xilinx/2018-November/004087.html), fails to build 'virtual/bootloader' due to missing PMUFW file: "Cannot read ../../../../../../pmutmp/deploy/images/zynqmp-pmu/pmu-firmware-zynqmp-pmu.bin" which is fair enough, since no one requested the build of it. This appears to be a regression since Sumo, where the dependency indeed was in place (because of the above definition): bitbake virtual/bootloader -e | grep ^DEPENDS= DEPENDS="virtual/aarch64-gomspace-linux-gcc virtual/aarch64-gomspace-linux-compilerlibs virtual/libc swig-native python-native bc-native dtc-native openssl-native virtual/pmu-firmware" It looks to me as Manju's proposal of adding it as an image dependency may work when building the image, but appears to be subject to a race condition between pmu-firmware and virtual/bootloader. Br, Martin # determine the path relative to the source tree relpath = os.path.relpath(d.expand("${DEPLOY_DIR_IMAGE}/pmu-${MACHINE}.bin"), d.getVar("S")) # setup PMU Firmware path via MAKEFLAGS -- 2.7.4 -- _______________________________________________ meta-xilinx mailing list [email protected] https://lists.yoctoproject.org/listinfo/meta-xilinx
