Thanks Manju,
On Thu, May 16, 2019 at 12:17 AM Manjukumar Harthikote Matha <
[email protected]> wrote:
> Hi Ben,
>
>
>
> I think the issue is that we have set arch override with = instead ?=
>
> Maybe the best bet is to have BIF_PARTITION_ATTR_zynqmp ?=
>
I definitely think the ?= is needed. The _zynqmp does take precedence for
ultrascale targets, so the documentation involving BIF_PARTITION_ATTR would
need some updating too.
Given the recipe includes machine-xilinx-${MACHINE}.inc, could it be
specified there instead (patch below).
>
>
> For time being, you could use machine override for your case
>
> BIF_PARTITION_ATTR_zcu102-zynqmp ?=
>
>
>
I hadn't thought of that, seems so obvious now :P but yes that works for me.
Ben
diff --git a/recipes-bsp/bootbin/machine-xilinx-zynqmp.inc
b/recipes-bsp/bootbin/machine-xilinx-zynqmp.inc
index 3cc2f8b..4aef017 100644
--- a/recipes-bsp/bootbin/machine-xilinx-zynqmp.inc
+++ b/recipes-bsp/bootbin/machine-xilinx-zynqmp.inc
@@ -2,7 +2,7 @@
BIF_COMMON_ATTR ?= ""
# specify BIF partition attributes required for BOOT.bin
-BIF_PARTITION_ATTR ?= "fsbl pmu atf u-boot"
+BIF_PARTITION_ATTR ?= "${@'fsbl pmu atf u-boot' if
d.getVar('FPGA_MNGR_RECONFIG_ENABLE') == '1' else 'fsbl bitstream pmu atf
u-boot'}"
# specify BIF partition attributes for FSBL
# bootloader is FSBL. Location where FSBL binary is present and dependency
to build FSBL
diff --git a/recipes-bsp/bootbin/xilinx-bootbin_1.0.bb
b/recipes-bsp/bootbin/xilinx-bootbin_1.0.bb
index 1fb8d99..40b15f5 100644
--- a/recipes-bsp/bootbin/xilinx-bootbin_1.0.bb
+++ b/recipes-bsp/bootbin/xilinx-bootbin_1.0.bb
@@ -19,8 +19,6 @@ BIF_FILE_PATH ?= "${B}/bootgen.bif"
BOOTGEN_EXTRA_ARGS ?= ""
-BIF_PARTITION_ATTR_zynqmp = "${@'fsbl pmu atf u-boot' if
d.getVar('FPGA_MNGR_RECONFIG_ENABLE') == '1' else 'fsbl bitstream pmu atf
u-boot'}"
-
do_fetch[noexec] = "1"
do_unpack[noexec] = "1"
do_patch[noexec] = "1"
>
> *From:* [email protected] [mailto:
> [email protected]] *On Behalf Of *Ben Coughlan
> *Sent:* Wednesday, May 15, 2019 1:07 AM
> *To:* [email protected]
> *Subject:* [meta-xilinx] [meta-xilinx-tools] BIF_PARTITION_ATTR Soft
> Assignment
>
>
>
> Hey All,
>
>
>
> Just bumping my tools up to 2018.3 and has just one issue with
> meta-xilinx-tools (actually using rel-v2019.1 because 2018.3 depended on
> peta-linux....)
>
>
>
> I'm overriding my bootbin partitions by providing BIF_PARTITION_* in my
> machine.conf, but it appears xilinx-bootbin no longer allows me to add
> partitions. I've added a patch below to allow my expected behaviour, and
> I've removed the zynqmp override.
>
>
>
> Given the README mentions overriding this variable I feel like I may have
> miss-understood something, as I wouldn't expect it to work as documented...
>
>
>
> Curious to hear any thoughts.
>
>
>
> Ben
>
>
>
> diff --git a/recipes-bsp/bootbin/xilinx-bootbin_1.0.bb
> b/recipes-bsp/bootbin/xilinx-bootbin_1.0.bb
>
> index 1fb8d99..cdef4dd 100644
>
> --- a/recipes-bsp/bootbin/xilinx-bootbin_1.0.bb
>
> +++ b/recipes-bsp/bootbin/xilinx-bootbin_1.0.bb
>
> @@ -19,7 +19,7 @@ BIF_FILE_PATH ?= "${B}/bootgen.bif"
>
>
>
> BOOTGEN_EXTRA_ARGS ?= ""
>
>
>
> -BIF_PARTITION_ATTR_zynqmp = "${@'fsbl pmu atf u-boot' if
> d.getVar('FPGA_MNGR_RECONFIG_ENABLE') == '1' else 'fsbl bitstream pmu atf
> u-boot'}
> <$%7b@'fsbl%20pmu%20atf%20u-boot'%20if%20d.getVar('FPGA_MNGR_RECONFIG_ENABLE')%20==%20'1'%20else%20'fsbl%20bitstream%20pmu%20atf%20u-boot'%7d>
> "
>
> +BIF_PARTITION_ATTR ?= "${@'fsbl pmu atf u-boot' if
> d.getVar('FPGA_MNGR_RECONFIG_ENABLE') == '1' else 'fsbl bitstream pmu atf
> u-boot'}
> <$%7b@'fsbl%20pmu%20atf%20u-boot'%20if%20d.getVar('FPGA_MNGR_RECONFIG_ENABLE')%20==%20'1'%20else%20'fsbl%20bitstream%20pmu%20atf%20u-boot'%7d>
> "
>
>
>
> do_fetch[noexec] = "1"
>
> do_unpack[noexec] = "1"
>
>
>
> --
>
> *Ben Coughlan*
> VP Software Engineering
> Canberra, Australia
> O: +61 2 6171 9730 <+61261719730>
> W: liquidinstruments.com <http://www.liquidinstruments.com/>
>
>
>
--
*Ben Coughlan*
VP Software Engineering
Canberra, Australia
O: +61 2 6171 9730 <+61261719730>
W: liquidinstruments.com <http://www.liquidinstruments.com/>
--
_______________________________________________
meta-xilinx mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-xilinx
