[PATCH 2/8] over: avoid excessive SELECT

[Eric Wong (Contractor, The Linux Foundation)]

No need to read what we don't need into the Perl process.
Fix some broken capitalization while we're at it.
---
 lib/PublicInbox/Over.pm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/lib/PublicInbox/Over.pm b/lib/PublicInbox/Over.pm
index da0f11e..07e54b6 100644
--- a/lib/PublicInbox/Over.pm
+++ b/lib/PublicInbox/Over.pm
@@ -59,7 +59,7 @@ sub do_get {
 sub query_xover {
        my ($self, $beg, $end) = @_;
        do_get($self, <<'', {}, $beg, $end);
-SELECT * FROM over WHERE num >= ? AND num <= ?
+SELECT num,ts,ds,ddd FROM over WHERE num >= ? AND num <= ?
 ORDER BY num ASC
 
 }
@@ -131,7 +131,7 @@ sub recent {
                }
        }
        my $msgs = do_get($self, <<"", $opts, @v);
-SELECT * FROM over WHERE $s
+SELECT ts,ds,ddd FROM over WHERE $s
 
        return $msgs unless wantarray;
 
@@ -145,7 +145,7 @@ sub get_art {
        my ($self, $num) = @_;
        my $dbh = $self->connect;
        my $smsg = $dbh->selectrow_hashref(<<'', undef, $num);
-SELECT * from OVER where num = ? LIMIT 1
+SELECT num,ds,ts,ddd FROM over WHERE num = ? LIMIT 1
 
        return load_from_row($smsg) if $smsg;
        undef;
-- 
EW

--
unsubscribe: meta+unsubscr...@public-inbox.org
archive: https://public-inbox.org/meta/