Eric Wong <[email protected]> wrote:
> Leah Neukirchen <[email protected]> wrote:
> > 1) RFC5322/822 invalid Date: headers should be parsed more gracefully
> >
> > Some old mails had Date: headers without time zones, e.g.
> > Date: Sat, 27 Sep 1997 10:02:32
> >
> > This results in public-inbox asserting this is the current date.
> > But this assumption makes no sense (literally every other guess
> > would be more likely), and also results in these messages showing up
> > on the first page of the archive. Furthermore, sorting is then not
> > stable, pressing F5 make the threads jump around. I'd recommend
> > falling back to +0000 instead.
>
> I think a fallback to +0000 makes sense, too.
> It's not a new bug in 1.3.0 (which makes Date::Parse optional).
>
> Looks like that regression was introduced a while ago in
> commit ae80a3fdb53d70142624f2691ed8ed84eddda66b
> ("MsgTime.pm: Use strptime to compute the time zone")
>
> Cc-ing Eric W. Biederman in case he has any input on this.
> ------------8<------------
> Subject: [RFC] msgtime: assume +0000 if TZ missing when using Date::Parse
Pushed as commit d857e7dc0d816b635a7ead09c3273f8c2d2434be
with a more descriptive commit message:
msgtime: assume +0000 if TZ missing when using Date::Parse
Some old emails don't have timezone offsets, since our
Date::Parse code path takes a liberal interpretation of dates,
fallback to using "+0000" as the timezone offset since it's
closer to the actual date of the message than whatever the
current date is.
Reported-by: Leah Neukirchen <[email protected]>
Link: https://public-inbox.org/meta/[email protected]/
Fixes: ae80a3fdb53d7014 ("MsgTime.pm: Use strptime to compute the time
zone")
Thanks
--
unsubscribe: one-click, see List-Unsubscribe header
archive: https://public-inbox.org/meta/
