stop_idle was a noop when the client issues a "DONE"
continuation or just disconnects. This would not have
led to a long term memory leak since FDs get closed and
reused, anyways, and all of our InboxIdle mappings are
keyed by FD.
---
lib/PublicInbox/IMAP.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/IMAP.pm b/lib/PublicInbox/IMAP.pm
index d4ef6efe..373bffc1 100644
--- a/lib/PublicInbox/IMAP.pm
+++ b/lib/PublicInbox/IMAP.pm
@@ -351,7 +351,7 @@ sub cmd_idle ($$) {
}
sub stop_idle ($$) {
- my ($self, $ibx);
+ my ($self, $ibx) = @_;
my $sock = $self->{sock} or return;
my $fd = fileno($sock);
delete $IDLERS->{$fd};
--
unsubscribe: one-click, see List-Unsubscribe header
archive: https://public-inbox.org/meta/
