I don't know if it's worth it to use libcurl directly (nor the effort to support and maintain tests) --- lib/PublicInbox/LeiCurl.pm | 2 ++ lib/PublicInbox/LeiExternal.pm | 3 +++ 2 files changed, 5 insertions(+)
diff --git a/lib/PublicInbox/LeiCurl.pm b/lib/PublicInbox/LeiCurl.pm index f346a1b4..3a79fbf8 100644 --- a/lib/PublicInbox/LeiCurl.pm +++ b/lib/PublicInbox/LeiCurl.pm @@ -2,6 +2,8 @@ # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt> # common option and torsocks(1) wrapping for curl(1) +# Eventually, we may support using libcurl via Inline::C and/or +# WWW::Curl; but curl(1) is most prevalent and widely-installed. package PublicInbox::LeiCurl; use strict; use v5.10.1; diff --git a/lib/PublicInbox/LeiExternal.pm b/lib/PublicInbox/LeiExternal.pm index b402eed4..8a51afcb 100644 --- a/lib/PublicInbox/LeiExternal.pm +++ b/lib/PublicInbox/LeiExternal.pm @@ -44,6 +44,8 @@ sub ext_canonicalize { } } +# TODO: we will probably extract glob2re into a separate module for +# PublicInbox::Filter::Base and maybe other places my %re_map = ( '*' => '[^/]*?', '?' => '[^/]', '[' => '[', ']' => ']', ',' => ',' ); @@ -99,6 +101,7 @@ sub get_externals { (); } +# TODO: does this need JSON output? sub lei_ls_external { my ($self, $filter) = @_; my $opt = $self->{opt}; -- unsubscribe: one-click, see List-Unsubscribe header archive: https://public-inbox.org/meta/
