Eric Wong <[email protected]> wrote:
> We'll be completing more options with ':', '//' and '=' in the
> future, so make it easier to disable trailing spaces on
> completions.

<snip>

> +++ b/contrib/completion/lei-completion.bash
> @@ -4,14 +4,12 @@
>  # preliminary bash completion support for lei (Local Email Interface)
>  # Needs a lot of work, see `lei__complete' in lib/PublicInbox::LEI.pm
>  _lei() {
> -     case ${COMP_WORDS[@]} in
> -     *' add-external h'* | *' --mirror h'*)
> -             compopt -o nospace
> -             ;;
> +     local wordlist="$(lei _complete ${COMP_WORDS[@]})"
> +     case $wordlist in
> +     *':'* | *'='* | '//'*) compopt -o nospace ;;

While this is nicer than before, I'm still wondering if there's
a better way for lei to communicate "-o nospace" to bash...
(or similar options for other shells)

Thanks in advance for any ideas you might provide.

>       *) compopt +o nospace ;; # the default
>       esac
> -     COMPREPLY=($(compgen -W "$(lei _complete ${COMP_WORDS[@]})" \
> -                     -- "${COMP_WORDS[COMP_CWORD]}"))
> +     COMPREPLY=($(compgen -W "$wordlist" -- "${COMP_WORDS[COMP_CWORD]}"))
>       return 0
>  }
>  complete -o default -o bashdefault -F _lei lei
--
unsubscribe: one-click, see List-Unsubscribe header
archive: https://public-inbox.org/meta/

Reply via email to