Recently I've tried lei on another machine and scratched my head for a
bit about why the local storage seemed to be in a corrupt state. With
`lei q', no mail was getting imported, and I saw a good number of
"fatal: not a git repository: ..." messages.
It turns out that HEAD's content is invalid, and that's happening
because PublicInbox::Import mishandles init.defaultBranch, which I've
configured on that machine to suppress the associated `git init' hint.
-- >8 --
Subject: [PATCH] import: convert init.defaultBranch to fully qualified ref
init.defaultBranch expects a branch name, not a fully qualified ref.
git-init prepends "refs/heads/" automatically and unconditionally.
PublicInbox::Import::default_branch, however, incorrectly passes on
the init.defaultBranch value as is, leading to it being used in spots
where a fully qualified ref is required. For example, with an
init.defaultBranch value of "master", public-inbox-index for a v2
repository would lead to an all.git repository where HEAD's content is
"ref: master" instead of "ref: refs/heads/master".
Prepend "refs/heads/" to the incoming init.defaultBranch value.
Fixes: 7c2f36de2fb49dd7 (import: respect init.defaultBranch)
---
lib/PublicInbox/Import.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/PublicInbox/Import.pm b/lib/PublicInbox/Import.pm
index 46f57e27..3adf9dec 100644
--- a/lib/PublicInbox/Import.pm
+++ b/lib/PublicInbox/Import.pm
@@ -25,7 +25,7 @@ sub default_branch () {
{ GIT_CONFIG => undef });
chomp(my $h = <$r> // '');
close $r;
- $h eq '' ? 'refs/heads/master' : $h;
+ $h eq '' ? 'refs/heads/master' : "refs/heads/$h";
}
}
base-commit: 86c2ebf085cc9897bafcb95b82890f2645f515e5
--
2.31.1
