On Mon, Sep 27, 2021 at 07:33:46PM +0000, Eric Wong wrote: > Konstantin Ryabitsev <[email protected]> wrote: > > t/v2mirror.t ................. 71/? W: > > /tmp/pi-v2mirror-39373-Dl1N/m/git/3.git missing remote.origin.url > > fatal: not a git repository: '/tmp/pi-v2mirror-39373-Dl1N/m/git/3.git' > > git --git-dir=/tmp/pi-v2mirror-39373-Dl1N/m/git/3.git fetch -q failed > > Bailout called. Further testing stopped: -fetch failed > > FAILED--Further testing stopped: -fetch failed > > make: *** [test_dynamic] Error 255 > > > > FYI, this is git 2.31.1. > > I'm not seeing this at all with 2.31.1, 2.20, 2.33... > I wonder if there's a permissions problem or some latent GIT_* > var in env... > > Are you testing as root? I think that would be broken, yes.
Yes, this is testing as root, largely because automatic deployment makes it hard to do the checkout/make/make test as an unprivileged user. I appreciate that in most other scenarios the final step would be "sudo make install" but when things are installed via configuration management, the process usually runs as root already and su-ing to a user for "make test" is adding more complication to the process. > The partial fetching would need some work to support working as > root. Ah. Just catch this with check if if id=0 and skipping the test as "known not to work for this use-case." -K
