Kyle Meyer <[email protected]> wrote:
> I've been noticing a good number of these error messages:
>
>   E: BUG {try_gits} empty at 
> /usr/local/share/perl/5.28.1/PublicInbox/SolverGit.pm line 80.

Thanks, the following should fix it (though I suppose @INC paths
should be cleaned in WWW):
------8<-----
Subject: [PATCH] inbox: do not vivify {-repo_objs} during cleanup

This caused config->repo_objs to not fill in {-repo_objs}
properly before starting solver.

Reported-by: Kyle Meyer <[email protected]>
Link: https://public-inbox.org/meta/[email protected]/
Fixes: 63d7b8ceee55a34 ("daemons: revamp periodic cleanup task")
---
 lib/PublicInbox/Inbox.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/PublicInbox/Inbox.pm b/lib/PublicInbox/Inbox.pm
index c525f4d1..95467d5a 100644
--- a/lib/PublicInbox/Inbox.pm
+++ b/lib/PublicInbox/Inbox.pm
@@ -30,7 +30,7 @@ sub do_cleanup {
        my ($ibx) = @_;
        my $live = git_cleanup($ibx);
        $ibx->cleanup_shards and $live = 1;
-       for my $git (@{$ibx->{-repo_objs}}) {
+       for my $git (@{$ibx->{-repo_objs} // []}) {
                $live = 1 if $git->cleanup(1);
        }
        delete @$ibx{qw(over mm description cloneurl
--
unsubscribe: one-click, see List-Unsubscribe header
archive: https://public-inbox.org/meta/

Reply via email to