Eric Wong writes:
>> @@ -47,6 +53,7 @@ Documentation/lei-q.pod
>> Documentation/lei-rediff.pod
>> Documentation/lei-refresh-mail-sync.pod
>> Documentation/lei-rm.pod
>> +Documentation/lei-rm-watch.pod
>> Documentation/lei-security.pod
>> Documentation/lei-store-format.pod
>> Documentation/lei-tag.pod
>
> Curious, was that from `git ls-files >MANIFEST' ?
No, it wasn't. I hadn't realized that the content of MANIFEST
corresponded directly to git-ls-files output, but poking around I see
there is even a check-manifest make target [*]. Doh.
So, I manually added this one, like the others I added. I think my past
changes to this file have ended up in the expected order because I tend
to run Emacs's sort-lines to check my manual placement, but I must not
have done it here because sort-lines agrees with ls-files.
[...]
> No big deal, I can just flip and push it; I just don't want a
> reproducibility issue popping up.
Thanks, sorry about the mix up.
[*] I did run `make check' before sending, and it looks like that also
checks MANIFEST _after_ running the test suite. That didn't help me
catch the MANIFEST sorting issue in this case because the test suite
is failing on my end.
I believe these failures are recent and was planning on looking into
them today, either sending a patch or just reporting, depending on
whether I could figure out a fix. Anyway, here they are:
t/psgi_multipart_not.t .......
ok 1 - use HTTP::Request::Common;
ok 2 - use Plack::Test;
ok 3 - use PublicInbox::WWW;
not ok 4 - /v2test/?q=%22ain't what it used to be%22&x=t
not ok 5 - /v2test/?q=%22ain't what it used to be%22&x=t warns
Failed 2/5 subtests
