On 2021-10-27 04:20+0000, Eric Wong wrote: > Thomas Weißschuh <[email protected]> wrote: > > diff --git a/lib/PublicInbox/SolverGit.pm b/lib/PublicInbox/SolverGit.pm > > index 5d5060f4..f9ce3793 100644 > > --- a/lib/PublicInbox/SolverGit.pm > > +++ b/lib/PublicInbox/SolverGit.pm > > @@ -18,6 +18,7 @@ use PublicInbox::Qspawn; > > use PublicInbox::Tmpfile; > > use PublicInbox::GitAsyncCat; > > use PublicInbox::Eml; > > +use PublicInbox::Import; > > I'm hesitant to add PublicInbox::Import to code used in > read-only daemons. > > > @@ -304,7 +306,7 @@ EOF > > close $fh or die "close git/config: $!"; > > > > open $fh, '>', "$git_dir/HEAD" or die "open git/HEAD: $!"; > > - print $fh "ref: refs/heads/master\n" or die "print git/HEAD: $!"; > > + print $fh "ref: $default_branch\n" or die "print git/HEAD: $!"; > > Having a global init.defaultBranch set doesn't seem to affect > SolverGit at all, and everything in solver repos is short-lived.
Yesterday I thought this was necessary to get one of the unittests to pass. As you can not confirm it and I can't neither today it seems to have been an error on my part. Let's drop this patch. > Replacing "master" with "s" might be an option for saving a > teeny bit of memory traffic, here. *shrug*
