Rob Herring <[email protected]> wrote: > On Mon, Nov 8, 2021 at 2:22 PM Konstantin Ryabitsev > > I think 's:patch AND nq:diff' is a good option here. > > Not even close really. That mainly finds my replies with 'diff' in > them. I'm not sure why, but it misses most actual patches: > > https://lore.kernel.org/all/?q=s%3Apatch+nq%3Adiff+f%3Arobh%40kernel.org
Actually, it looks like nq:diff never works. The diff indexer skips right over 'diff --git a/... b/...' lines :x The following should fix it, but reindexing is necessary. ---------8<---------- Subject: [PATCH] searchidx: index "diff --git a/... b/..." headers While we do detailed indexing of git diffs, the header itself was failing and queries like 'nq:diff' would not work. Noticed-by: Rob Herring <[email protected]> --- lib/PublicInbox/SearchIdx.pm | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/PublicInbox/SearchIdx.pm b/lib/PublicInbox/SearchIdx.pm index b886ce78..6e2e614c 100644 --- a/lib/PublicInbox/SearchIdx.pm +++ b/lib/PublicInbox/SearchIdx.pm @@ -259,6 +259,7 @@ sub index_diff ($$$) { } elsif (m!^diff --git "?[^/]+/.+ "?[^/]+/.+\z!) { # wait until "---" and "+++" to capture filenames $in_diff = 1; + push @xnq, $_; # traditional diff: } elsif (m/^diff -(.+) (\S+) (\S+)$/) { my ($opt, $fa, $fb) = ($1, $2, $3); -- unsubscribe: one-click, see List-Unsubscribe header archive: https://public-inbox.org/meta/
