Julien Moutinho <[email protected]> wrote: > Without Inline::C, and without Nix's sandbox > -------------------------------------------- > > I get 3 tests to fail (in addition to those currently disabled in Nixpkgs: > https://github.com/NixOS/nixpkgs/pull/104457/files#diff-77474340b38081fea7ce3b112c1bc060d3a95cc5e781915463e2f3fc5556da7bR34-R69 > ie. convert-compact, search, v2writable, www_listing, eml, hl_mod, > lei-mirror and spawn): > $ nix develop -f . public-inbox > $ doCheck= bash pkgs/development/perl-modules/generic/builder.sh > $ make -C public-inbox-1.7.0 test > > [...] > > Test Summary Report > > ------------------- > > t/nntpd-v2.t (Wstat: 256 Tests: 113 Failed: 1) > > Failed test: 102 > > Non-zero exit status: 1 > > t/nntpd.t (Wstat: 256 Tests: 110 Failed: 1) > > Failed test: 99 > > Non-zero exit status: 1 > > t/solver_git.t (Wstat: 1280 Tests: 13 Failed: 5) > > Failed tests: 9-13 > > Non-zero exit status: 5 > > Parse errors: No plan found in TAP output > > Files=149, Tests=4658, 296 wallclock secs ( 1.78 usr 0.56 sys + 116.73 > > cusr 165.82 csys = 284.89 CPU) > > Result: FAIL > > Failed 3/149 test programs. 7/4658 subtests failed. > > More precisely: > $ (cd public-inbox-1.7.0; perl -I$out/lib/perl5/site_perl t/nntpd-v2.t ) > > [...] > > ok 101 - new article retrieved after compact > > not ok 102 - no deleted files > > # Failed test 'no deleted files' > > # at ./t/nntpd.t line 363. > > # Structures begin differing at: > > # $got->[0] = '-nntpd 3130714 julm 4u REG > > 0,53 77189 2606550 /tmp/nix-shell.D0VGvX (deleted)
OK, so that's a false positive for a deleted file that wasn't created by public-inbox. I suppose our tests can be altered to account for that. Is nix-shell setting FD_CLOEXEC on all FDs (>= 3) it creates? IMNSHO it should. It seems to be standard practice nowadays to set FD_CLOEXEC on all FDs (>=3) created. At least that's my experience with Perl 5.6+ and Ruby 2.0+; I'll let experts in other languages chime in for other stuff... More on the rest in a separate email(s). -- unsubscribe: one-click, see List-Unsubscribe header archive: https://public-inbox.org/meta/
