Julien Moutinho <[email protected]> wrote: > Le dim. 27 févr. 2022 16h23 +0900, Dominique Martinet a écrit : > > I guess we can now open a nix issue asking to reset signal handlers > > after fork, before executing its builder?... > Well spotted Dominique, thanks! > > Turns out this is actually systemd which ignores SIGPIPE. > I'm able to pass t/lei-sigpipe.t when my `nix build` > connects to a nix-daemon run manually outside systemd. > There is already a 3yo issue on nix's tracker for that: > https://github.com/NixOS/nix/issues/2803 > suggesting to add to nix-daemon.service: > > [Service] > > IgnoreSIGPIPE=no > And that indeed also makes t/lei-sigpipe.t succeed. > > In the meantime I'll disable t/lei-sigpipe.t > to finally get public-inbox added to Nixpkgs. > > Thank you Dominique and Eric!
You're welcome and thank you for tracking this down. Yes, blocking SIGPIPE makes sense for most daemons so I think systemd is being reasonable, here. However, this lei test is for simulating an interactive environment, so re-enabling SIGPIPE under t/lei-sigpipe.t seems best... I initially considered adding this for all test_lei(), but most lei tests don't care and I didn't want to waste CPU time. ------8<----- Subject: [PATCH] t/lei-sigpipe: ensure SIGPIPE is unblocked for this test Tests run under systemd (and similar) have SIGPIPE blocked by default. This was causing this SIGPIPE test to get stuck when run by automated builders used by Nix. Thanks to Julien Moutinho and Dominique Martinet for tracking down this failure. Reported-by: Julien Moutinho <[email protected]> Reported-by: Dominique Martinet <[email protected]> Link: https://public-inbox.org/meta/[email protected]/ --- t/lei-sigpipe.t | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/t/lei-sigpipe.t b/t/lei-sigpipe.t index 6b2772a6..7fab9aeb 100644 --- a/t/lei-sigpipe.t +++ b/t/lei-sigpipe.t @@ -1,10 +1,25 @@ #!perl -w -# Copyright (C) 2021 all contributors <[email protected]> +# Copyright (C) all contributors <[email protected]> # License: AGPL-3.0+ <https://www.gnu.org/licenses/agpl-3.0.txt> use strict; use v5.10.1; use PublicInbox::TestCommon; -use POSIX qw(WTERMSIG WIFSIGNALED SIGPIPE); +use POSIX qw(WTERMSIG WIFSIGNALED SIGPIPE SIG_UNBLOCK SIG_SETMASK sigprocmask); +use PublicInbox::OnDestroy; + +# undo systemd (and similar) blocking SIGPIPE, since lei expects to be run +# from an interactive terminal: +# https://public-inbox.org/meta/[email protected]/ +my $set = POSIX::SigSet->new; +my $old = POSIX::SigSet->new; +$set->emptyset or xbail "sigemptyset $!"; +$old->emptyset or xbail "sigemptyset $!"; +$set->addset(SIGPIPE); +sigprocmask(SIG_UNBLOCK, $set, $old) or xbail "SIG_UNBLOCK: $!"; +my $cleanup = PublicInbox::OnDestroy->new($$, sub { + sigprocmask(SIG_SETMASK, $old); +}); + test_lei(sub { my $f = "$ENV{HOME}/big.eml"; my $imported; -- unsubscribe: one-click, see List-Unsubscribe header archive: https://public-inbox.org/meta/
