[PATCH] git: write_all: remove leftover debug messages

[Eric Wong]

Chris Brannon <ch...@the-brannons.com> wrote:
> The conversion seems to have been successful, but it logged very many of
> the following:
> E: Resource temporarily unavailable at
> /usr/share/perl5/vendor_perl/PublicInbox/Git.pm line 320.
> 
> I'm sorry, I didn't count how many.  It seemed like multiple screenfuls
> at least.

Oops, yeah.   Just leftover debug messages that never triggered
on my FreeBSD and Debian systems.  Will push this out:

---------8<----------
Subject: [PATCH] git: write_all: remove leftover debug messages

I used these messages during development to verify Alpine was
triggering the intended codepaths.  They're no longer necessary
and just noise at this point.

Reported-by: Chris Brannon <ch...@the-brannons.com>
Fixes: d4ba8828ab23 ("git: fix asynchronous batching for deep pipelines")
---
 lib/PublicInbox/Git.pm | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/PublicInbox/Git.pm b/lib/PublicInbox/Git.pm
index 86b80a4e..c7f82ba2 100644
--- a/lib/PublicInbox/Git.pm
+++ b/lib/PublicInbox/Git.pm
@@ -315,11 +315,10 @@ sub write_all {
                my $w = syswrite($out, $buf);
                if (defined $w) {
                        return if $w == length($buf);
-                       warn "chop: $w";
                        substr($buf, 0, $w, ''); # sv_chop
                } elsif ($! != EAGAIN) {
                        $self->fail("write: $!");
-               } else { warn "E: $!" }
+               }
                $read_step->($self, $inflight);
        } while (1);
 }