'-' could never match, remove that alternative (it might have been a
typo of '--', but that is already covered by '*--|--*' ('*' matches
the null string)).

Replace '*--*' with the equivalent '*' ('--' is always present).

It would seem clearer to just replace the whole case command with
something like '[ "$ID" -a "$VERSION_ID" ] && break' (or the
POSIX-non-deprecated equivalent '[ "$ID" ] && [ "$VERSION_ID" ]' ); I
assume a preference of using case here (e.g., to avoid syscall
overhead in case [ is not implemented as a shell builtin (which seems
far-fetched given the context, though)).
---
 ci/profiles.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ci/profiles.sh b/ci/profiles.sh
index 3cd8fa38756a..e58b61d50a13 100755
--- a/ci/profiles.sh
+++ b/ci/profiles.sh
@@ -30,8 +30,8 @@ GNU/Linux)
                esac
 
                case $ID--$VERSION_ID in
-               -|*--|--*) continue ;;
-               *--*) break ;;
+               *--|--*) continue ;;
+               *) break ;;
                esac
        done
        ;;

base-commit: a036772bdf732d4779f44974095bfdd0b30271ef
-- 
2.42.0


Reply via email to