On Fri, 01 Sep 2023 11:09:03 +0000 Eric Wong wrote: > Štěpán Němec <[email protected]> wrote: >> Ah, I see now that PERFORMANCE NOTES in lei-overview.pod says Inline::C >> is required, so perhaps just some adjustments to the test >> skipping/diagnostics and INSTALL instructions (which say Inline::C is >> optional) would be helpful? > > Actually, Inline::C is only needed for lei on *BSDs nowadays. > Common/available-on-cfarm Linux arches can rely on stable > syscall numbers to do FD passing.
I see, thanks. How about this then: -- >8 -- Subject: [PATCH] Clarify Inline::C dependency (optional on Linux, required elsewhere) Link: https://public-inbox.org/meta/20230901110903.M876537@dcvr/ Fixes: 88c7c7c26b44 ("lei: wire up pure Perl sendmsg/recvmsg for Linux users") Fixes: acefd91b302d ("syscall: implement sendmsg+recvmsg in pure Perl") --- Documentation/lei-overview.pod | 12 +++++++----- INSTALL | 7 ++++--- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/Documentation/lei-overview.pod b/Documentation/lei-overview.pod index 7095b504cdb8..e9a97d64fb56 100644 --- a/Documentation/lei-overview.pod +++ b/Documentation/lei-overview.pod @@ -119,11 +119,13 @@ code repository. =head1 PERFORMANCE NOTES -L<Inline::C> is required, lei runs as a background daemon to reduce -startup costs and can provide real-time L<kqueue(2)>/L<inotify(7)> -Maildir monitoring. L<IO::KQueue> (p5-IO-KQueue on FreeBSD) and -L<Linux::Inotify2> (liblinux-inotify2-perl and perl-Linux-Inotify2 in -.deb and .rpm-based distros, respectively) are recommended. +L<Inline::C> is required on BSDs and can speed things up on Linux. + +lei runs as a background daemon to reduce startup costs and can +provide real-time L<kqueue(2)>/L<inotify(7)> Maildir monitoring. +L<IO::KQueue> (p5-IO-KQueue on FreeBSD) and L<Linux::Inotify2> +(liblinux-inotify2-perl and perl-Linux-Inotify2 in .deb and .rpm-based +distros, respectively) are recommended. L<Socket::MsgHdr> is optional (libsocket-msghdr-perl in Debian), and further improves startup performance. Its effect is most felt diff --git a/INSTALL b/INSTALL index 5f080f2889ce..e8d686d8f21b 100644 --- a/INSTALL +++ b/INSTALL @@ -60,7 +60,7 @@ Where "deb" indicates package names for Debian-derived distributions, "pkg" is for the FreeBSD package (maybe other common BSDs, too), and "rpm" is for RPM-based distributions (only known to work on Fedora). -Numerous optional modules are likely to be useful as well: +Numerous other modules are likely to be useful as well: - DBD::SQLite deb: libdbd-sqlite3-perl pkg: p5-DBD-SQLite @@ -76,8 +76,9 @@ Numerous optional modules are likely to be useful as well: - Inline::C deb: libinline-c-perl pkg: p5-Inline-C rpm: perl-Inline (or perl-Inline-C) - (speeds up process spawning on Linux, - see public-inbox-daemon(8)) + (required for lei on *BSD; speeds up process + spawning on Linux, see + public-inbox-daemon(8)) - Email::Address::XS deb: libemail-address-xs-perl pkg: p5-Email-Address-XS -- 2.42.0
