ProcessIO being tied is problematic since perlops like stat and fcntl don't work directly on the handle, and we need separate classes to do buffered read and unbuffered sysread.
It's possible to do as common packages (e.g. File::Temp, IO::Socket::IP, IO::Socket::SSL) do by subclassing IO::Handle to avoid tie completely. I also want to avoid the self-tie thing IO::Socket::SSL to avoid having to rely on weaken(). So, this essentially becomes a war on `close($fh)' an relying on $fh->close where appropriate. This loses some usefulness of autodie, so we keep `close($fh)' for places which aren't tied at the moment. One key place is to replace many calls to popen_rd with the new run_qx to consolidate close calls. There's also few other cleanups, code reductions, and safety improvements along the way. And more changes coming. Eric Wong (10): spawn: croak directly in C pi_fork_exec spawnpp: use autodie for syscall failures spawn: avoid alloca in C pi_fork_exec git: use run_qx to read `git --version' git: avoid extra stat(2) for git version gcf2: simplify pkg-config and Inline::C setup treewide: use run_qx where appropriate www_altid: reduce FD pressure in qspawn queues xt/eml_check_limits: remove useless import lei_ale: use v5.12, autodie, and try_cat lib/PublicInbox/Admin.pm | 7 ++--- lib/PublicInbox/Config.pm | 14 ++++----- lib/PublicInbox/Fetch.pm | 7 ++--- lib/PublicInbox/Gcf2.pm | 27 +++++----------- lib/PublicInbox/Git.pm | 15 +++++---- lib/PublicInbox/Import.pm | 6 ++-- lib/PublicInbox/LEI.pm | 7 ++--- lib/PublicInbox/LeiALE.pm | 24 +++++++-------- lib/PublicInbox/LeiBlob.pm | 12 +++----- lib/PublicInbox/LeiMirror.pm | 7 ++--- lib/PublicInbox/MultiGit.pm | 7 ++--- lib/PublicInbox/Spamcheck/Spamc.pm | 11 ++----- lib/PublicInbox/Spawn.pm | 49 +++++++++++++++--------------- lib/PublicInbox/SpawnPP.pm | 10 +++--- lib/PublicInbox/WwwAltId.pm | 9 ++---- lib/PublicInbox/XapHelperCxx.pm | 11 ++----- t/solver_git.t | 12 +++----- xt/eml_check_limits.t | 4 +-- 18 files changed, 94 insertions(+), 145 deletions(-)
