Seems like a good place to start. The only real caveat I'd add is that one of the subtle things which Norm was doing which might not even have been fully noticeable is that he had a bias towards "merge this now" which I think generally served us well. Now sometimes that was combined with "please make a follow up to fix x, y, and z", or applied more to uncontroversial changes than to everything, or had some details like "we can rename it later if we find a better name" or the like.
But that is a subtlety which doesn't really contradict anything being suggested below. Just something to keep in mind if our pull request queue seems like it is growing and pull requests linger for a long time without being either merged or closed. On December 13, 2021 10:20:07 AM PST, "David A. Wheeler" <[email protected]> wrote: >Sadly, Norm is no longer with us. We're going to have to work out next steps. > >Norm typically made the final decision of what to accept or not accept into >the set.mm database. >We're going to have to find another process. > >I would suggest, for now, that proposed changes continue to be added as GitHub >pull requests. >Obviously any change *must* pass the automated checks to be considered for >merging. >Others can "approve" by going to the "Files Changed" tab and click on "review >changes". >If you approve, click on "approve" and then "submit review". Or you could just >say "+1" as a comment. >If after several days (I suggest 5) there's another approver who has >*previously* had a change approved, >and no disagreement, I suggest merging it. If there's disagreement, discuss in >the comments to >try towards resolution (& if it's more contentious, also involve the mailing >list). > >We don't have to use this process. I'm just suggesting *a* process we can use. >If anyone would prefer another process, please speak up. > >--- David A. Wheeler > -- You received this message because you are subscribed to the Google Groups "Metamath" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/metamath/83116AEB-D11B-4BD6-BC8C-D72F1297C431%40panix.com.
