Thanks for your work on this, Josh. Much appreciated. On Tuesday, 18 February 2014 09:37:57 UTC-8, Josh Cartmell wrote: > > I never worried about it too much since it only affected admins. In the > past I've played around with popping up the editable form in a bootstrap > modal, but that requires the site to use Bootstrap, which probably isn't a > good assumption. > > I was just thinking (and tried it out which seemed to work) that we could > change ba-resize to define a baresize event, instead of overriding jquery's > default resize event. Getting this working required two changes. First > change the beginning of > https://github.com/stephenmcd/mezzanine/blob/faa736a0b42a6d6a92db13b46b9d322e2d5ffedc/mezzanine/core/static/mezzanine/js/jquery.ba-resize.min.jsfrom > > > e=$.resize=$.extend($.resize,{}) > > to > > e=$.baresize=$.extend($.baresize,{}) > > Then change > https://github.com/stephenmcd/mezzanine/blob/faa736a0b42a6d6a92db13b46b9d322e2d5ffedc/mezzanine/core/static/mezzanine/js/editable.js#L68to: > > $('.editable-original').on('baresize', function(e) { > > I did this and although I didn't test things super thoroughly the inline > editing popups still pop up. > > There may be a better approach, but what do you guys think? > > > > On Mon, Feb 17, 2014 at 9:15 PM, Stephen McDonald <[email protected]<javascript:> > > wrote: > >> I can tell you one thing at least, it only occurring when logged in as an >> admin user is no mystery - the file only gets used for the live editing: >> >> >> https://github.com/stephenmcd/mezzanine/blob/master/mezzanine/core/templates/includes/editable_loader.html >> >> I can't speak for the rest of it, its introduction was 2 years ago: >> >> >> https://github.com/stephenmcd/mezzanine/commit/faa736a0b42a6d6a92db13b46b9d322e2d5ffedc >> >> Seems to be related to managing the position of the live editing overlay >> - would welcome throwing out the lib in question if there's a better >> approach. >> >> >> >> On Tue, Feb 18, 2014 at 4:11 PM, Ross Laird <[email protected]<javascript:> >> > wrote: >> >>> That's interesting -- yes, I see this error only when I am logged in as >>> admin. >>> I have installed some extra javascript (such as headroom.js and the >>> prettify jQuery plugin), so one of those could be interacting with >>> ba-resize. But it's tough for me to know how to debug this further. It's >>> not a huge issue, as no regular user to the site will experience this error. >>> >>> >>> On Monday, 17 February 2014 17:54:30 UTC-8, Josh Cartmell wrote: >>> >>>> Hey Ross, I've seen this before. >>>> >>>> Tell me if I'm wrong but do you only see it when you log in as an >>>> admin? In my experience, it had something to do with a jquery script >>>> trying to use the normal jquery resize functionality ( >>>> https://api.jquery.com/resize/) and not working because ba-resize >>>> changes the way .resize works. >>>> >>>> Steve, I can't find/think of a concrete example off the top of my head, >>>> but if I do I'll definitely post it up. >>>> >>>> >>>> On Mon, Feb 17, 2014 at 5:36 PM, Stephen McDonald <[email protected]>wrote: >>>> >>>>> Any hints on how to reproduce? >>>>> >>>>> >>>>> On Tue, Feb 18, 2014 at 11:59 AM, Ross Laird <[email protected]>wrote: >>>>> >>>>>> I'm getting a javascript error ("Uncaught TypeError: cannot set >>>>>> property of 'w' undefined") with jquery.ba-resize.js, which is included >>>>>> in >>>>>> the default Mezzanine setup. There is an open >>>>>> issue<https://github.com/cowboy/jquery-resize/issues/1> about >>>>>> this at the jquery-resize repo, but it seems that the repo has not been >>>>>> updated in four years. Anybody else have this issue, or any thoughts >>>>>> about >>>>>> updating this add-on for Mezzanine? >>>>>> >>>>>> -- >>>>>> You received this message because you are subscribed to the Google >>>>>> Groups "Mezzanine Users" group. >>>>>> To unsubscribe from this group and stop receiving emails from it, >>>>>> send an email to [email protected]. >>>>>> >>>>>> For more options, visit https://groups.google.com/groups/opt_out. >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Stephen McDonald >>>>> http://jupo.org >>>>> >>>>> -- >>>>> You received this message because you are subscribed to the Google >>>>> Groups "Mezzanine Users" group. >>>>> To unsubscribe from this group and stop receiving emails from it, send >>>>> an email to [email protected]. >>>>> >>>>> For more options, visit https://groups.google.com/groups/opt_out. >>>>> >>>> >>>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Mezzanine Users" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected] <javascript:>. >>> For more options, visit https://groups.google.com/groups/opt_out. >>> >> >> >> >> -- >> Stephen McDonald >> http://jupo.org >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Mezzanine Users" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/groups/opt_out. >> > >
-- You received this message because you are subscribed to the Google Groups "Mezzanine Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
