Thanks for feedback, guys. Very helpful. As you know, I learn by breaking, so it's helpful for me to know what kinds of things are likely to break.
On Monday, 10 March 2014 11:03:34 UTC-7, Josh Cartmell wrote: > > Hey Ross, I don't have a great understanding of south, but I think those > dictionaries show what South thinks the current state of the models are. > > The following is a bit of conjecture: > > By commenting out the keywords it will be as if south doesn't know they > exist when it's running migrations (or at least can't access them). Since > in actuality they do exist in the db this isn't really a problem unless you > had a migration running on an app that wanted to access the keywords (or > other Mezzanine generic field) of a different model. > > The above probably isn't spot on, but I don't think there is much of a > risk involved in commenting out the generic fields. > > > On Sun, Mar 9, 2014 at 4:55 PM, Stephen McDonald <[email protected]<javascript:> > > wrote: > >> I only vaguely recall and can't verify right now, but if I recall >> correctly, migrations won't be generated with the keywords field with the >> latest south/Django versions, and in your case, commenting them out is the >> correct approach - this was done in Mezzanine as well when this became the >> case. >> >> Sorry I can't provide an exhaustive response - there are many layers to >> this which just aren't fresh. >> >> >> On Mon, Mar 10, 2014 at 8:31 AM, Ross Laird <[email protected]<javascript:> >> > wrote: >> >>> I have read the >>> description<https://groups.google.com/forum/#!searchin/mezzanine-users/keywords/mezzanine-users/LGxEfHgxPok/AbsrnPlaIp4J> >>> of >>> the changes to how Mezzanine handles generic relations, but I don't really >>> understand the programming aspects well enough to know if I'm going to have >>> trouble with my approach to removing generic references in other apps (such >>> as the events app <https://github.com/stbarnabas/mezzanine-events>). >>> For example, when I did the initial migration for the events app, I got the >>> error message about conflicts with South: >>> >>> Your project contains migrations that include one of the fields >>> from mezzanine.generic in its Migration.model dict: possibly >>> KeywordsField, CommentsField or RatingField... >>> >>> Josh had already given me a hint about that error message, with regard >>> to another app (my fantastic theme app <http://mezzathe.me/>, crafted >>> by Josh), so I just did the same thing as previously: I commented out the >>> line that referred to the keywords. Here's the line I commented out: >>> >>> #'keywords': ('mezzanine.generic.fields.KeywordsField', [], >>> {'object_id_field': "'object_pk'", 'to': "orm['generic.AssignedKeyword']",\ >>> 'frozen_by_south': 'True'}), >>> >>> After doing this, the events app migrates fine and works fine. But I >>> suppose I'd like to know if there are likely to be any unintended >>> (negative) consequences of just arbitrarily knocking out an entire line of >>> code from an app. I've now done this for two apps, and I expect I might >>> need to do it again, as I add new things. So, before I go too far down the >>> road of just blithely commenting out code blocks, I should know a bit about >>> what might happen. >>> >>> Can anyone offer any insight about this? >>> >>> Thanks in advance. >>> >>> Ross >>> >>> >>> -- >>> You received this message because you are subscribed to the Google >>> Groups "Mezzanine Users" group. >>> To unsubscribe from this group and stop receiving emails from it, send >>> an email to [email protected] <javascript:>. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> >> >> -- >> Stephen McDonald >> http://jupo.org >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Mezzanine Users" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected] <javascript:>. >> For more options, visit https://groups.google.com/d/optout. >> > > -- You received this message because you are subscribed to the Google Groups "Mezzanine Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
