Looks like all tests are passing.
On Tue, Apr 22, 2014 at 7:54 PM, Kevin Golding
<kevingolding2...@gmail.com>wrote:
> Hi Stephen
> Thanks for the timely response.
> When you mentioned the bad/missing Pillow install I recalled that I
> originally had some issues with Pillow. I think Pillow itself has a number
> of (possibly undocumented?) dependencies and things go quite wrong if they
> are not met when you try to install.
>
> In the end I started from scratch and created a new VM, and made sure that
> I had all the dependencies that I could find for Pillow before attempting
> to install it. Then I followed the steps exactly in your 'Contributing'
> section with the exception that I specified 'pyflakes==0.6.1 pep8==1.4.1'
> when installing these bits, as per the "test_require" line in setup.py.
>
> Now when I run the tests it ends up saying "OK (skipped=2, expected
> failures=1)".
>
> Is this close enough in terms of 'all tests passing'? I don't see anything
> about failures in the output, though I get a number of warnings about
> things being deprecated (which is why I'm doing all this in the first
> place).
>
> Regards
> Kevin
>
>
>
>
> On Sunday, April 20, 2014 5:22:36 PM UTC-7, Stephen McDonald wrote:
>
>> Those all look like dependency issues.
>>
>> Making sure you've got the correct versions of the test dependencies (as
>> per `tests_require` in setup.py) should fix the first failure.
>>
>> The second and third look due to a bad/missing PIL/Pillow install.
>>
>> The failures against Django 1.7 are expected - there's a lot of work to
>> be done there.
>>
>>
>> On Mon, Apr 21, 2014 at 9:48 AM, Kevin Golding <kevingol...@gmail.com>wrote:
>>
>>>
>>> Hi all
>>> I was planning to make some changes for things that are deprecated in
>>> Django1.7, so I forked Mezzanine on bitbucket and did all the steps in the
>>> "Contributing" section to create a development environment (but using my
>>> fork on bitbucket instead of the github one listed).
>>>
>>> However before I made any actual changes I ran the 'manage.py test'
>>> command just to see how it worked, and it reported 3 errors.
>>>
>>> I'm not really sure what to do now. If I make my changes will the pull
>>> request be rejected because the tests don't pass for unrelated reasons?
>>>
>>> I've pasted in the output of the test run below. Note that this is
>>> running against Django 1.6.2. I also have an environment set up with Django
>>> 1.7, and when I run the tests there I get 8 'errors' in addition to the 3
>>> 'failures'.
>>>
>>> Any suggestions what I should do now?
>>> Thanks
>>> Kevin
>>>
>>>
>>> =================================================================
>>> (mezz_dj16)kevin@ubuntu:~/mezzanine_dj16/mezzanine$
>>> ./mezzanine/project_template/manage.py test
>>> /home/kevin/mezzanine_dj16/mezzanine/mezzanine/utils/conf.py:51:
>>> UserWarning: You haven't defined the ALLOWED_HOSTS settings, which Django
>>> 1.5 requires. Will fall back to the domains configured as sites.
>>> warn("You haven't defined the ALLOWED_HOSTS settings, which "
>>> /home/kevin/mezzanine_dj16/mezzanine/mezzanine/utils/conf.py:59:
>>> UserWarning: TIME_ZONE setting is not set, using closest match:
>>> Australia/Sydney
>>> warn("TIME_ZONE setting is not set, using closest match: %s" % tz)
>>> Creating test database for alias 'default'...
>>> ............................................................
>>> .........................................x..................
>>> ............................................................
>>> .........................................................s..
>>> ..../home/kevin/mezzanine_dj16/mezz_dj16/local/lib/
>>> python2.7/site-packages/django/http/response.py:330:
>>> DeprecationWarning: Using mimetype keyword argument is deprecated, use
>>> content_type instead
>>> super(HttpResponse, self).__init__(*args, **kwargs)
>>>
>>> ...F......s........./home/kevin/mezzanine_dj16/mezz_
>>> dj16/local/lib/python2.7/site-packages/pkg_resources.py:991:
>>> UserWarning: /home/kevin/.python-eggs is writable by group/others and
>>> vulnerable to attack when used with get_resource_filename. Consider a more
>>> secure location (set with .set_extraction_path or the PYTHON_EGG_CACHE
>>> environment variable).
>>> warnings.warn(msg, UserWarning)
>>>
>>> FF
>>> ======================================================================
>>> FAIL: test_syntax (mezzanine.core.tests.CoreTests)
>>> ----------------------------------------------------------------------
>>> Traceback (most recent call last):
>>> File "/home/kevin/mezzanine_dj16/mezzanine/mezzanine/core/tests.py",
>>> line 72, in test_syntax
>>> self.fail("Syntax warnings!\n\n%s" % "\n".join(warnings))
>>> AssertionError: Syntax warnings!
>>>
>>> mezzanine/utils/tests.py:142: visually indented line with same indent as
>>> next logical line
>>> mezzanine/utils/docs.py:154: visually indented line with same indent as
>>> next logical line
>>> mezzanine/utils/docs.py:199: visually indented line with same indent as
>>> next logical line
>>> mezzanine/project_template/settings.py:251: block comment should start
>>> with '# '
>>> mezzanine/project_template/settings.py:252: block comment should start
>>> with '# '
>>> mezzanine/accounts/forms.py:215: visually indented line with same
>>> indent as next logical line
>>> mezzanine/core/middleware.py:204: visually indented line with same
>>> indent as next logical line
>>> mezzanine/core/managers.py:82: block comment should start with '# '
>>> mezzanine/core/managers.py:91: block comment should start with '# '
>>> mezzanine/core/managers.py:123: block comment should start with '# '
>>> mezzanine/core/tests.py:292: block comment should start with '# '
>>> mezzanine/core/tests.py:302: block comment should start with '# '
>>> mezzanine/core/tests.py:307: block comment should start with '# '
>>> mezzanine/core/tests.py:316: block comment should start with '# '
>>> mezzanine/blog/management/commands/import_rss.py:56: visually indented
>>> line with same indent as next logical line
>>> mezzanine/blog/management/commands/import_blogger.py:57: block comment
>>> should start with '# '
>>> mezzanine/blog/management/commands/import_blogger.py:61: block comment
>>> should start with '# '
>>> mezzanine/blog/management/commands/import_blogger.py:76: block comment
>>> should start with '# '
>>> mezzanine/pages/managers.py:27: visually indented line with same indent
>>> as next logical line
>>> mezzanine/forms/forms.py:194: visually indented line with same indent as
>>> next logical line
>>>
>>> ======================================================================
>>> FAIL: test_gallery_import (mezzanine.galleries.tests.GalleriesTests)
>>> ----------------------------------------------------------------------
>>> Traceback (most recent call last):
>>> File "/home/kevin/mezzanine_dj16/mezzanine/mezzanine/galleries/tests.py",
>>> line 27, in test_gallery_import
>>> self.assertTrue(images)
>>> AssertionError: [] is not true
>>>
>>> ======================================================================
>>> FAIL: test_thumbnail_generation (mezzanine.galleries.tests.
>>> GalleriesTests)
>>> ----------------------------------------------------------------------
>>> Traceback (most recent call last):
>>> File "/home/kevin/mezzanine_dj16/mezzanine/mezzanine/galleries/tests.py",
>>> line 48, in test_thumbnail_generation
>>> self.assertEqual(os.path.normpath(thumb_image.lstrip("/")),
>>> thumb_name)
>>> AssertionError: u'image.jpg' != u'.thumbnails/image.jpg/image-24x24.jpg'
>>> - image.jpg
>>> + .thumbnails/image.jpg/image-24x24.jpg
>>>
>>>
>>> ----------------------------------------------------------------------
>>> Ran 266 tests in 9.232s
>>>
>>> FAILED (failures=3, skipped=2, expected failures=1)
>>> Destroying test database for alias 'default'...
>>> (mezz_dj16)kevin@ubuntu:~/mezzanine_dj16/mezzanine$
>>>
>>> --
>>> You received this message because you are subscribed to the Google
>>> Groups "Mezzanine Users" group.
>>> To unsubscribe from this group and stop receiving emails from it, send
>>> an email to mezzanine-use...@googlegroups.com.
>>>
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>
>>
>> --
>> Stephen McDonald
>> http://jupo.org
>>
> --
> You received this message because you are subscribed to the Google Groups
> "Mezzanine Users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to mezzanine-users+unsubscr...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
>
--
Stephen McDonald
http://jupo.org
--
You received this message because you are subscribed to the Google Groups
"Mezzanine Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to mezzanine-users+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
