I was wondering if there was an update regarding this? It sounds like the answer to the question I've been searching for.
I've created a Mezzanine/Cartridge site for a client and have been asked why featured images and adding images from Rich Text Pages go through the media library but adding images to products is done in a different way meaning some images need uploading twice. Stewart On Monday, 30 September 2013 21:36:26 UTC+1, Stephen McDonald wrote: > > Awesome > > > On Tue, Oct 1, 2013 at 6:31 AM, step <[email protected]> wrote: > >> Hi Stephen, >> >> I made some initial changes to my fork at >> https://github.com/stepmr/cartridge . I'll add the zip upload stuff >> tommorow. Tests run, everything seems to work. Had to change the >> wishlists template but everything else worked without at hitch. >> >> Want to make sure I'm not missing anything big before I put in a pull >> request. Specifically I saw this: >> >> >>> >>> *I went to apply it to product images, but left it as there are some >>> extra things that go on with those that will need more work, and it wasn't >>> a priority. Specifically the image's URL gets copied over to products in >>> the cart >>> (https://github.com/stephenmcd/cartridge/blob/master/cartridge/shop/models.py#L492 >>> >>> <https://github.com/stephenmcd/cartridge/blob/master/cartridge/shop/models.py#L492>) >>> >>> so that the products need not be queried themselves when dealing with the >>> cart. * >> >> >> >>> *So a little bit of extra work needs to happen there, but yes eventually >>> Cartridge product images should use the filebrowser file field >>> (mezzanine.core.fields.FileField specifically). If you'd like to get this >>> working that'd be great, otherwise I'll get to it at some point.* >> >> >> Not sure where this is happening... >> >> > Aha wow, bless you for finding that. I knew yesterday there was an > outstanding issue related but couldn't recall. This is it. > > Here's the code related: > > > https://github.com/stephenmcd/cartridge/blob/master/cartridge/shop/models.py#L555-L557 > > So cart items have no explicit relationship to their products/variations - > things like the image get copied over in that code when added to the cart. > > > >> >> On Sunday, September 29, 2013 10:09:51 PM UTC-4, Stephen McDonald wrote: >> >>> I vaguely recall meaning to fix that for quite some time. >>> >>> I believe it's that way as Cartridge images came before the >>> FileField/folebrowser integration in Mezzanine. >>> >>> If you'd like to make it happen please go for it. >>> >>> >>> On Mon, Sep 30, 2013 at 12:04 PM, step <[email protected]> wrote: >>> >>>> Hey guys, >>>> >>>> Does anyone know the specifics as to why Cartridge's ProductImage Model >>>> uses ImageField and not FileField? Was planning on adding FileField and >>>> Zip Upload (Like Mezzanine's Gallery Model) to Products... but wanted to >>>> check in first to make sure I'm not headed towards trouble... >>>> >>>> - S >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Mezzanine Users" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> >>>> For more options, visit https://groups.google.com/groups/opt_out. >>>> >>> >>> >>> >>> -- >>> Stephen McDonald >>> http://jupo.org >>> >> >> On Sunday, September 29, 2013 10:09:51 PM UTC-4, Stephen McDonald wrote: >> >>> I vaguely recall meaning to fix that for quite some time. >>> >>> I believe it's that way as Cartridge images came before the >>> FileField/folebrowser integration in Mezzanine. >>> >>> If you'd like to make it happen please go for it. >>> >>> >>> On Mon, Sep 30, 2013 at 12:04 PM, step <[email protected]> wrote: >>> >>>> Hey guys, >>>> >>>> Does anyone know the specifics as to why Cartridge's ProductImage Model >>>> uses ImageField and not FileField? Was planning on adding FileField and >>>> Zip Upload (Like Mezzanine's Gallery Model) to Products... but wanted to >>>> check in first to make sure I'm not headed towards trouble... >>>> >>>> - S >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Mezzanine Users" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> >>>> For more options, visit https://groups.google.com/groups/opt_out. >>>> >>> >>> >>> >>> -- >>> Stephen McDonald >>> http://jupo.org >>> >> >> On Sunday, September 29, 2013 10:09:51 PM UTC-4, Stephen McDonald wrote: >> >>> I vaguely recall meaning to fix that for quite some time. >>> >>> I believe it's that way as Cartridge images came before the >>> FileField/folebrowser integration in Mezzanine. >>> >>> If you'd like to make it happen please go for it. >>> >>> >>> On Mon, Sep 30, 2013 at 12:04 PM, step <[email protected]> wrote: >>> >>>> Hey guys, >>>> >>>> Does anyone know the specifics as to why Cartridge's ProductImage Model >>>> uses ImageField and not FileField? Was planning on adding FileField and >>>> Zip Upload (Like Mezzanine's Gallery Model) to Products... but wanted to >>>> check in first to make sure I'm not headed towards trouble... >>>> >>>> - S >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Mezzanine Users" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> >>>> For more options, visit https://groups.google.com/groups/opt_out. >>>> >>> >>> >>> >>> -- >>> Stephen McDonald >>> http://jupo.org >>> >> >> On Sunday, September 29, 2013 10:09:51 PM UTC-4, Stephen McDonald wrote: >> >>> I vaguely recall meaning to fix that for quite some time. >>> >>> I believe it's that way as Cartridge images came before the >>> FileField/folebrowser integration in Mezzanine. >>> >>> If you'd like to make it happen please go for it. >>> >>> >>> On Mon, Sep 30, 2013 at 12:04 PM, step <[email protected]> wrote: >>> >>>> Hey guys, >>>> >>>> Does anyone know the specifics as to why Cartridge's ProductImage Model >>>> uses ImageField and not FileField? Was planning on adding FileField and >>>> Zip Upload (Like Mezzanine's Gallery Model) to Products... but wanted to >>>> check in first to make sure I'm not headed towards trouble... >>>> >>>> - S >>>> >>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Mezzanine Users" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> >>>> For more options, visit https://groups.google.com/groups/opt_out. >>>> >>> >>> >>> >>> -- >>> Stephen McDonald >>> http://jupo.org >>> >> -- >> You received this message because you are subscribed to the Google Groups >> "Mezzanine Users" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/groups/opt_out. >> > > > > -- > Stephen McDonald > http://jupo.org > -- You received this message because you are subscribed to the Google Groups "Mezzanine Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
