Hi Eduardo, Yes, it took me a while to find the source of the problem but it is sorted in the pull request.
You click on your own repo 'pull requests' to generate the pull request. I'm still fairly new to it myself but it is a very nice feature of github. Before generating the pull request you need to update your repo with the upstream branch to avoid complications.... and yes, you can only do the pull requests for your fork so steps further up are in the hands of those repo owners. You can probably 'short circuit' a non responsive upstream fork by forking Mathias's repo, merging our changes into it and generating a pull request from your new repo (I hope that makes sense - it sounds more complex than it actually is). I've not had any problem with the front-end language selector - it is displaying fine on my pages because it is explicitly set up in the base template. Cheers, Paul On 24 July 2014 11:09, Eduardo Rivas <[email protected]> wrote: > Hi Paul. It seems like you sorted out the issue you were linking too. Are > there any others? > > I finally found some time to come back to this, and noticed the front-end > language selector is gone. The problem is in the condition for rendering the > template > <https://github.com/Kniyl/mezzanine/blob/master/mezzanine/core/templates/includes/language_selector.html#L3>, > as settings.USE_MODELTRANSLATION won't be available in the template context > unless explicitly added to TEMPLATE_ACCESSIBLE_SETTINGS, thus, it always > returns False and the template is never rendered. Relevant page > <http://mezzanine.jupo.org/docs/configuration.html#template-accessible-settings> > in the official docs. > > While we are at this, I'm unsure how contributions to forks work. It seems > I cannot make pull requests to Mathias' fork. Maybe because it has never > been merged into Steve's repo (the "upstream" repo)? Anyways, I've made the > necessary edits here > <https://github.com/jerivas/mezzanine/commit/5a4fa67dbba7a4aed493535c28fc991b0f1a3d61>, > guess you'll have to manually copy it to your repo, Mathias. I'm not sure > if core.defaults is the best place to put this, let me know what you guys > think. > > -- > You received this message because you are subscribed to a topic in the > Google Groups "Mezzanine Users" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/mezzanine-users/VXVfCU8OFGk/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- You received this message because you are subscribed to the Google Groups "Mezzanine Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
