Hey, the fixes look good - can you create a pull request? BTW don't think this is necessary:
https://github.com/dfirst/mezzanine/blob/fix_generic_tests_dfirst/mezzanine/generic/tests.py#L20 Just use the setting directly. On Thu, Aug 13, 2015 at 4:39 PM, <[email protected]> wrote: > Hi every body i wrote some fixes for generic.tests. > Here how to catch bugs: add this to settings : > > > RATINGS_ACCOUNT_REQUIRED = True > COMMENTS_ACCOUNT_REQUIRED = True > RATINGS_RANGE = [-1, 1] > > and then run tests you will get about 5 errors, so i fixed tests for these > settings and now they work well. Everything works well. Rating system works > as it expected to work. > Here is the link: > https://github.com/dfirst/mezzanine/blob/fix_generic_tests_dfirst/mezzanine/generic/tests.py. > > > PS. Pls anybody answer to me what is the right way to tell if i found a bug > or fixed or implemented some thing? > > -- > You received this message because you are subscribed to the Google Groups > "Mezzanine Users" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Stephen McDonald http://jupo.org -- You received this message because you are subscribed to the Google Groups "Mezzanine Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
