After reading through the discussion here

https://code.djangoproject.com/ticket/23581

I believe that all that needs to happen is for the initial migration to be 
edited so that it references settings.SHOP_ORDER_STATUS_CHOICES, rather 
than the literal values. The same works for the default attribute as well 
as for choices. Once this is done, the user can supply their own version of 
settings.SHOP_ORDER_STATUS_CHOICES and the Django autodetector doesn't see 
this as a change.

I'll submit a PR that does this.

On Thursday, November 5, 2015 at 5:51:21 PM UTC+11, Chris Trengove wrote:
>
> I think moving the handling to the form field should do it. Though there 
> is the issue of what to do about the Model default, which currently is set 
> to SHOP_ORDER_STATUS_CHOICES[0][0], which presently is just "1". Obviously, 
> it wouldn't be too much of a restriction to insist that any user-defined 
> list of choices uses a 1-based list. 
>
>
> On Thursday, November 5, 2015 at 11:29:56 AM UTC+11, Stephen McDonald 
> wrote:
>>
>>
>> On Thu, Nov 5, 2015 at 11:24 AM, Stephen McDonald <[email protected]> wrote:
>>
>>> I suspect in Cartridge we'll need to set it on the order explicitly when 
>>> it gets created, rather than changing a form field.
>>
>>
>> Somehow I had in my head that we were talking about the default value, 
>> but SHOP_ORDER_STATUS_CHOICES defines the choices, so maybe we can just 
>> move its handling onto the form field.
>>
>>
>> -- 
>> Stephen McDonald
>> http://jupo.org
>>
>

-- 
You received this message because you are subscribed to the Google Groups 
"Mezzanine Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to