Thanks for your responses Josh, my own are inline:

> 1. Most clients I have worked with have existing SKUs for products so this
> makes it easier for those to be tied together.


Fair enough.

2. There might be another reason but its also a limitation of Django
> Inlines. Also there is a way to change this functional but can cause other
> issues.


It seems like it would just be a matter of changing the `extra` or
`min_num` attribute on the inline. Perhaps I'll encounter the "other
issues" if I try this.

3. This is a tough one as we wouldn't want the Unit Price to be required,
> as I have had clients add products but not want them available for sale.


There's already a `Product.available` field to handle this use case. Rather
than make the `ProductVariation.unit_price` required, what if we made the
`Product.available` validator require there to be at least one variation
with a price in order to set it to `True`?


On Wed, May 11, 2016 at 10:51 PM, Josh B <[email protected]>
wrote:

> Hey Ryne,
>
> 1. Most clients I have worked with have existing SKUs for products so this
> makes it easier for those to be tied together.
> 2. There might be another reason but its also a limitation of Django
> Inlines. Also there is a way to change this functional but can cause other
> issues.
> 3. This is a tough one as we wouldn't want the Unit Price to be required,
> as I have had clients add products but not want them available for sale.
>
>
> On Wednesday, May 11, 2016 at 12:18:36 PM UTC-6, Ryne Everett wrote:
>>
>> The following observations and screenshots are from a fresh cartridge
>> 0.11 project I just made.
>>
>>    1. Why are sku fields editable? Cartridge uses them essentially as
>>    foreign key's. Is there any use case for editing a sku from the admin?
>>    Seems like a user could really screw things up with no appreciation for
>>    what's going on under the hood.
>>    2. You can't edit ProductVariation's until you initially save the
>>    Product:  Is this intentional, a bug, or a limitation of django admin
>>    inlines?
>>    3. Until one adds a "unit price" to a variation, a product is
>>    unavailable: But there is no indication that this is a problem in the
>>    admin. Is this intentional, a bug, or a limitation of django admin? It
>>    seems to me that this is probably unfixable without addressing #2 -- if 
>> you
>>    have to save the Product before editing the ProductVariation's, then
>>    causing the Product validation to fail when a ProductVariation is missing 
>> a
>>    required field is not an option.
>>
>> --
> You received this message because you are subscribed to the Google Groups
> "Mezzanine Users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to [email protected].
> For more options, visit https://groups.google.com/d/optout.
>

-- 
You received this message because you are subscribed to the Google Groups 
"Mezzanine Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
For more options, visit https://groups.google.com/d/optout.

Reply via email to