Thanks Stephen - I've opened an issue to track this: https://github.com/stephenmcd/cartridge/issues/298
On 29 June 2016 at 16:00, Stephen McDonald <[email protected]> wrote: > > > On Wed, Jun 29, 2016 at 3:49 PM, Sam Kingston <[email protected]> wrote: > >> I'd say probably use the one Eduardo suggests: >> https://github.com/incuna/django-wkhtmltopdf since it is has more >> seamless support for Django and does the same thing as mine (calls out to >> the wkhtmltopdf static binary). >> >> Mine is for more low level, generic Python usage, though I do use it for >> a large Cartridge site successfully. >> > > That actually sounds more suited to what Cartridge needs - the PDF > integration is just a couple of lines. > > I also think that you both owning the library, and also being a long-time > Mezzanine contributor, is worth a lot, if the difference between the two > libraries is negligible in what we're doing. > > >> >> Would you like me to raise an issue and investigate if one would work >> better for Cartridge? >> > > That'd be awesome, thanks! > > >> >> On 29 June 2016 at 13:40, Stephen McDonald <[email protected]> wrote: >> >>> Cool Sam! >>> >>> Do you think we should use your library in Cartridge instead of >>> whatever's being used now? >>> >>> On Wed, Jun 29, 2016 at 11:22 AM, Sam Kingston <[email protected]> wrote: >>> >>>> I'm not sure if this will help you or not, but I developed a >>>> replacement library for xhtml2pdf (though not a drop-in): >>>> >>>> https://github.com/sjkingo/pywkhtmltopdf >>>> >>>> >>>> On Friday, 24 June 2016 20:13:05 UTC+10, Joseph Mohan wrote: >>>>> >>>>> Any other things i'm missing with regards to getting an image into the >>>>> .pdf invoices? >>>>> >>>>> Set the url to a full path >>>>> >>>>> Tried .png/.jpg >>>>> >>>>> Nothing... >>>>> >>>>> Any ideas? >>>>> >>>>> -- >>>> You received this message because you are subscribed to the Google >>>> Groups "Mezzanine Users" group. >>>> To unsubscribe from this group and stop receiving emails from it, send >>>> an email to [email protected]. >>>> For more options, visit https://groups.google.com/d/optout. >>>> >>> >>> >>> >>> -- >>> Stephen McDonald >>> http://jupo.org >>> >>> -- >>> You received this message because you are subscribed to a topic in the >>> Google Groups "Mezzanine Users" group. >>> To unsubscribe from this topic, visit >>> https://groups.google.com/d/topic/mezzanine-users/AicXbbQzd7w/unsubscribe >>> . >>> To unsubscribe from this group and all its topics, send an email to >>> [email protected]. >>> For more options, visit https://groups.google.com/d/optout. >>> >> >> >> >> -- >> Sam Kingston Mobile: 0439 074 638 >> SJK Web Industries Web: www.sjkingston.com >> Brisbane, Qld, Australia Email: [email protected] >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Mezzanine Users" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to [email protected]. >> For more options, visit https://groups.google.com/d/optout. >> > > > > -- > Stephen McDonald > http://jupo.org > > -- > You received this message because you are subscribed to a topic in the > Google Groups "Mezzanine Users" group. > To unsubscribe from this topic, visit > https://groups.google.com/d/topic/mezzanine-users/AicXbbQzd7w/unsubscribe. > To unsubscribe from this group and all its topics, send an email to > [email protected]. > For more options, visit https://groups.google.com/d/optout. > -- Sam Kingston Mobile: 0439 074 638 SJK Web Industries Web: www.sjkingston.com Brisbane, Qld, Australia Email: [email protected] -- You received this message because you are subscribed to the Google Groups "Mezzanine Users" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
