Hi Karel, On 5/24/19 10:38 AM, Karel Gardas wrote: > > Hi Michael, > > your changes generally looks fine, although I'm highly curious why do you > still (in 2019) need single-threaded build.
Well, this is some older application with CORBA parts untouched for a decade, and I'm unsure what may happen when threads are enabled in mico. As the code to disable threads in mico still is around and was easy enough to fix, I just haven't seen need to try the application with mico threads enabled. > > On the other hand, I've attempted to merge them here using GNU patch and this > process failed miserably as all hunks were rejected. Not sure if my MUA has > not corrupted patches in some way. > Anyway, I've pushed my working tree now so you can darcs pull and see > yourself if the issue is with patches you provided or they apply fine on your > end and then I would request them in gziped GNU patch format not to give mu > MUA chance to corrupt them. Patch updates on the way in plain text for discussion and patch.gz attached. Thanks! /haubi/ > > Thanks! > Karel > > On 05/22/19 05:01 PM, Michael Haubenwallner wrote: >> Hi, >> >> I'm about to update mico in a situation with threads disabled, >> and face compilation errors because of two distinct problems: >> >> 1) HAVE_THREADS not being defined causes compilation errors, >> and the first patch does fix them. >> >> 2) The idl compiler dumps core when optimization is enabled, >> and valgrind does show some invalid memory read after free. >> This eventually is because ORBInvokeRec is ref-counted since 2014, >> but ORB::_cache_rec does not respect that. Fixed by second patch. >> >> What do you think? >> >> Thanks! >> /haubi/ >> >> >> >> >> _______________________________________________ >> Mico-devel mailing list >> Mico-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/mico-devel >> > > _______________________________________________ Mico-devel mailing list Mico-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/mico-devel
