Fwd: Re: [Microdia] Re: [PUSHED] development becomes master

[Vasily Khoruzhick]

Forwarding original message to the group

--- Begin Message ---

Vasily Khoruzhick schrieb:

On 28 November 2008 22:12:07 GWater wrote:

Oh,
I never got that patch I think. (Otherwise I would have pushed it ;) .)

Patch attached :)

Anyway - it is correct that we currently don't have any more functions
to cover with V4L2 CIDs but this is easy to change. I still can only
think of black-level calibration but if we go over the datasheets we may
find some other expert stuff.

Sounds OK, btw it seems that datasheet for my ov9650 lies too often, even for gain registers :( so I'm afraid I will not be very usefull here. First thing we should think about is how to add V4L2-controls specific for sensors, but not globally.

I just keep talking about these things because I really like madwifi and
these guys also implemented everything they could find and a bit more.

Makes it easier for the users to decide they want and does not bind them
to the default settings some developer hardcoded into the driver.

GWater

BTW The AUTO-exposure CID I put in there only works for >=2.6.25 . I'll
try to fix this.
GWater

Vasily

Here is the V4L2 fix for older kernels.


GWater

From 20ae6a6f8efc977c2da83792442350433c3b75c6 Mon Sep 17 00:00:00 2001
From: GWater <[EMAIL PROTECTED]>
Date: Fri, 28 Nov 2008 21:34:07 +0100
Subject: [PATCH] Fix build problems for kernel < 2.6.25 because of undefined 
V4L2_CID

        The V4L2 spec claims that the changes were included into kernel
        2.6.25 therefore I also changed the #if statement.

Signed-off-by: GWater <[EMAIL PROTECTED]>
---
 microdia-v4l.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/microdia-v4l.c b/microdia-v4l.c
index c42826d..ce2c206 100644
--- a/microdia-v4l.c
+++ b/microdia-v4l.c
@@ -40,8 +40,9 @@
 
 
 /* USER DEFINED V4L2-CONTROLS: */
-#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 26)
+#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 25)
 #define V4L2_CID_SHARPNESS             (V4L2_CID_PRIVATE_BASE + 0)
+#define V4L2_CID_EXPOSURE_AUTO         (V4L2_CID_PRIVATE_BASE + 1)
 #endif
 
 #if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 27)
-- 
1.6.0.4

I couldn' test but hopefully it works. I especilly need to know if kernel 2.6.25 works because the if-statement said it would not work but the V4L2 spec said it would. I trusted the spec.

signature.asc
Description: OpenPGP digital signature

--- End Message ---

signature.asc
Description: This is a digitally signed message part.