Hi This patch is probably not targeted for immediate commit to master, you will have to breakup the patch into a) making jpeg header struct static etc b) use likely/unlikely only for control-branching code path less likely in all/most situations c) using likely/unlikely for further optimizing for jpeg
a & b will be acceptable/welcome by us all (can be committed to master) c can be done in a separate branch. Using likely/unlikely is definitely a direction we would like to take ;-) probably its better to keep such changes as a set of patches until we decide to merge upstream. for measuring FPS you can record the stream, then while playback you can check the FPS of the available video. Another branch is now needed for the upstream merge, by removing all the #ifndefs etc for previous kernels for a start. Hey Vasily, is your touchpad etc usb as well that could be the reason you are facing usb bandwidth issues when using webcam ? Otherwise its surprising you were using bulk transfer mode. -JoJo On Sat, Jan 31, 2009 at 9:26 PM, Vasily Khoruzhick <[email protected]> wrote: > > > Nope, no go, > I'm using bulk transfer, and this patch will result in performance regression > for bulk transfers > --~--~---------~--~----~------------~-------~--~----~ Lets make microdia webcams plug'n play, (currently plug'n pray) To post to this group, send email to [email protected] Visit us online https://groups.google.com/group/microdia -~----------~----~----~----~------~----~------~--~---
