Josua Grawitter wrote: > Am Freitag 20 Mдrz 2009 10:05:06 schrieb Brian Johnson: > >> Ok just took a quick look at amsn source and yes the code for setting >> an attribute is definitely broken it checks the value tht you are >> setting for a range of 0 - 65535. this is definitely wrong as av4l2 >> control value is first of all signed and second of all it should be >> using its defined min/max values anyways. I attached a quick patch >> that fixes this issue with amsn in case anyone is interested. >> >> Also kopete seems to have two issues one it appears it also doesn't >> bother to consider that a control value can be negative and kopete >> actually natively knows bayer format whcih unless i use somethign like >> libv4l it will use by default. and none of the controls that use our >> bridges color matrix (hue/sat/contrast/brightness) work when using >> bayer since it is not being converted to YUV. this is one reason you >> should not use bayer unless there is no other choice. >> >> Also I'm of the mind that we should not modify our driver in order to >> fix broken applications. The more correct thing will be to patch the >> applications to properly follow v4l2 specs. In this case allow >> controls with negative values. >> >> > > I just did some testing: > 1. Somehow green/blue gain are still locked if AWB is enabled. I thought my > patch fixed that but apparently it didn't. > 2. Saturation, hue, etc work as expected, however ... > 3. If saturation is set to less than circa 40 my computer locks up. I suspect > the framerate drops and the buffer is unhappy but I can't tell exactly > because > there is no kernel-oops and dmesg looks fine after I reboot. > 4. Why do we keep a wrapper function which calls wrapper functions through a > set of pointers which in the end all end up with the same functions - for > hue, > saturation, blue/red gain, brightness, contrast and gamma there is only the > bridge functions so why not call them directly? And why not call > "sn9c20x_set_optical_parameters()" directly? > I think clearing that mess will make the module and the struct usb_sn9c20x at > least a bit smaller and also the code clearer. I'll post a patch once the > style isses are fixed. > > GWater > > > Good morning (depend of my local time ;-) ) I follow the style of programming for function call. Before to send as patch I call directly the function "sn9c20x_set_optical_parameters()". The freezing of computer is happened if function '..set_optical..' is too slow. I lost too much time to solve this problem. The 'freezing' is happened always if circle array with parameters declared as local for function '..set_optical..'. I have idea for some improvement of function but I wait for push of new patches for hue,set,bright... and your for camera button before do anything. The volume of patches is too hi to keep in local.
--~--~---------~--~----~------------~-------~--~----~ Lets make microdia webcams plug'n play, (currently plug'n pray) To post to this group, send email to [email protected] Visit us online https://groups.google.com/group/microdia -~----------~----~----~----~------~----~------~--~---
