On Friday 01 May 2009 11:08:24 you wrote: > On Friday 01 May 2009 07:55:55 Josua Grawitter wrote: > > Great. So who mails a patch/git-pull-request to the respnsible maintainer > > (GKH, isn't it?) ? > > > > GWater > > One more thing remains: > > tags file should be removed, it is not necessary for build :) > > Regards > Vasily
Oops, my fault, I didn't notice that it is not under version control. Btw, here's some patches to review Regards Vasily
From d1010518ab49f105688bf36031a8bb79b267580f Mon Sep 17 00:00:00 2001 From: Vasily Khoruzhick <[email protected]> Date: Fri, 1 May 2009 11:27:18 +0300 Subject: [PATCH 1/2] Change Kconfig to conform common style, make it like SN9C1xx Signed-off-by: Vasily Khoruzhick <[email protected]> --- Kconfig | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Kconfig b/Kconfig index 6d5a98c..97337b0 100644 --- a/Kconfig +++ b/Kconfig @@ -1,22 +1,22 @@ config USB_SN9C20X - tristate "sn9c20x usb webcams" + tristate "USB SN9C20x PC Camera Controller support" depends on VIDEO_V4L2 ---help--- - Say Y or M here if you have a usb webcam using the - sn9c20x chipset. + Say Y or M here if you want support for cameras based on SONiX + SN9C201 or SN9C202 PC Camera Controllers. To compile this driver as a module, choose M here: the module will be called "sn9c20x.ko". config USB_SN9C20X_DEBUGFS - bool "enable debugfs support" + bool "Enable debugfs support" depends on USB_SN9C20X ---help--- Say Y here in order to enable debugfs for sn9c20x webcams config USB_SN9C20X_EVDEV - bool "enable evdev support" + bool "Enable evdev support" depends on USB_SN9C20X ---help--- Say Y here in order to enable evdev support for sn9c20x webcam buttons. -- 1.6.2.3
From 1896f5bfe4824c4405ff00add2d0a2e884fef61c Mon Sep 17 00:00:00 2001 From: Vasily Khoruzhick <[email protected]> Date: Fri, 1 May 2009 11:27:31 +0300 Subject: [PATCH 2/2] Fix build with evdev disabled Signed-off-by: Vasily Khoruzhick <[email protected]> --- sn9c20x-usb.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/sn9c20x-usb.c b/sn9c20x-usb.c index 666547e..f0e0023 100644 --- a/sn9c20x-usb.c +++ b/sn9c20x-usb.c @@ -810,7 +810,7 @@ static int usb_sn9c20x_default_settings(struct usb_sn9c20x *dev) return 0; } - +#ifdef CONFIG_USB_SN9C20X_EVDEV static int input_thread(void *data) { struct usb_sn9c20x *dev = (struct usb_sn9c20x *)data; @@ -900,6 +900,7 @@ static void sn9c20x_input_cleanup(struct usb_sn9c20x *dev) dev->input_dev = NULL; } } +#endif /** * @brief Load the driver -- 1.6.2.3
signature.asc
Description: This is a digitally signed message part.
