Thanks guys for feedback. I fixed HTML parsing warnings. Have to look into JSON. Looks like I broke it while was adding fixes. Also will add to my list fix for infinite inclusion. Good point, Toby.

On 10/04/2008, at 7:08 PM, Toby A Inkster wrote:
Dmitry Baranovskiy wrote:

As always feedback is highly appreciated.

Just a few thoughts...

* Parsing <http://examples.tobyinkster.co.uk/hcard> issues a few warnings related to use of XHTML with namespaces. You might want to think about
 turning down PHP's error reporting. e.g.

     error_reporting(E_ERROR);

* Parsing same page with output as JSON I see (line break added):

     tel: [{, "type": "work""value": "+1 (310) 597 3781 work"},
     {, "type": "work""value": "+1 (310) 597 3781 work"}]}

 this is clearly garbled.

* There are other JSON output errors: e.g. not all strings are quoted.

I might have some more feedback when I've gone through your source code.

--
Toby A Inkster BSc (Hons) ARCS
[Geek of HTML/SQL/Perl/PHP/Python/Apache/Linux]
[OS: Linux 2.6.17.14-mm-desktop-9mdvsmp, up 14 days, 20:17.]

                  Tagliatelle with Fennel and Asparagus
  http://tobyinkster.co.uk/blog/2008/04/06/tagliatelle-fennel-asparagus/

_______________________________________________
microformats-discuss mailing list
microformats-discuss@microformats.org
http://microformats.org/mailman/listinfo/microformats-discuss

_______________________________________________
microformats-discuss mailing list
microformats-discuss@microformats.org
http://microformats.org/mailman/listinfo/microformats-discuss

Reply via email to